deep-stack/laconicd-deprecated
6
0
Fork 0
forked from cerc-io/laconicd-deprecated
Code Pull Requests Activity

fix ethermintcli->keys add algo flag defValue (#466)

Browse Source 
* fix ethermintcli->keys add algo flag defValue

* fix documentation and scripts

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
This commit is contained in:
wellplay 2020-08-25 17:06:47 +08:00 committed by GitHub
parent d2fbeed75b
commit 98610e4999
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
client/keys.go
View File

@ -38,6 +38,10 @@ func KeyCommands() *cobra.Command {
// update the default signing algorithm value to "eth_secp256k1"
algoFlag := addCmd.Flag("algo")
algoFlag.DefValue = string(crypto.EthSecp256k1)
err := algoFlag.Value.Set(string(crypto.EthSecp256k1))
if err != nil {
panic(err)
}
addCmd.RunE = runAddCmd
cmd.AddCommand(

4
docs/quickstart/run_node.md
View File

@ -47,7 +47,7 @@ ethermintd start
To run a node with the same key every time: replace `ethermintcli keys add $KEY` in `./init.sh` with:
```bash
echo "your mnemonic here" | ethermintcli keys add $KEY --recover --algo "eth_secp256k1"
echo "your mnemonic here" | ethermintcli keys add $KEY --recover
```
::: tip Ethermint currently only supports 24 word mnemonics.
@ -56,7 +56,7 @@ echo "your mnemonic here" | ethermintcli keys add $KEY --recover --algo "eth_sec
You can generate a new key/mnemonic with:
```bash
ethermintcli keys add $KEY --algo "eth_secp256k1"
ethermintcli keys add $KEY
```
To export your ethermint key as an ethereum private key (for use with Metamask for example):

4
docs/quickstart/testnet.md
View File

@ -57,7 +57,7 @@ minimum-gas-prices = ""
```bash
# Create a key to hold your account
ethermintcli keys add $KEY --algo "eth_secp256k1"
ethermintcli keys add $KEY
# Add that key into the genesis.app_state.accounts array in the genesis file
# NOTE: this command lets you set the number of coins. Make sure this account has some coins
@ -268,7 +268,7 @@ Now that accounts exists, you may create new accounts and send those accounts
funds!
::: tip
**Note**: Each node's seed is located at `./build/nodeN/ethermintcli/key_seed.json` and can be restored to the CLI using the `ethermintcli keys add --restore --algo "eth_secp256k1"` command
**Note**: Each node's seed is located at `./build/nodeN/ethermintcli/key_seed.json` and can be restored to the CLI using the `ethermintcli keys add --restore` command
:::
### Special Binaries

2
init.sh
View File

@ -18,7 +18,7 @@ ethermintcli config indent true
ethermintcli config trust-node true
# if $KEY exists it should be deleted
ethermintcli keys add $KEY --algo "eth_secp256k1"
ethermintcli keys add $KEY
# Set moniker and chain-id for Ethermint (Moniker can be anything, chain-id must be an integer)
ethermintd init $MONIKER --chain-id $CHAINID

2
scripts/integration-test-all.sh
View File

@ -74,7 +74,7 @@ arrcli=()
init_func() {
echo "create and add new keys"
"$PWD"/build/ethermintcli config keyring-backend test --home "$DATA_CLI_DIR$i"
"$PWD"/build/ethermintcli keys add $KEY"$i" --home "$DATA_CLI_DIR$i" --no-backup --chain-id $CHAINID --algo "eth_secp256k1"
"$PWD"/build/ethermintcli keys add $KEY"$i" --home "$DATA_CLI_DIR$i" --no-backup --chain-id $CHAINID
echo "init Ethermint with moniker=$MONIKER and chain-id=$CHAINID"
"$PWD"/build/ethermintd init $MONIKER --chain-id $CHAINID --home "$DATA_DIR$i"
echo "init ethermintcli with chain-id=$CHAINID and config it trust-node true"