deep-stack/laconicd-deprecated
4
0
Fork 0
forked from cerc-io/laconicd-deprecated
Code Pull Requests Activity

fix: eth_newPendingTransactionFilter doesn't return ethereum tx hash (#1012)

Browse Source 
* Problem: eth_newPendingTransactionFilter don't return correct tx hash

Closes: #1011
Solution:
- use eth tx hash rather than tendermint one

* changelog

* remove copied TODO comment and ignore err result of Notify

* add e2e test

* fix ws client in e2e test

* fix test

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
This commit is contained in:
yihuang
2022-03-24 07:56:59 +00:00
committed by GitHub
co-authored by Federico Kunze Küllmer
parent 42b5e443da
commit 70d52948da
5 changed files with 60 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
testutil/network/util.go
+1 -1
View File
@@ -128,7 +128,7 @@ func startInProcess(cfg Config, val *Validator) error {
}
tmEndpoint := "/websocket"
tmRPCAddr := fmt.Sprintf("tcp://%s", val.AppConfig.GRPC.Address)
tmRPCAddr := val.RPCAddress
val.jsonrpc, val.jsonrpcDone, err = server.StartJSONRPC(val.Ctx, val.ClientCtx, tmRPCAddr, tmEndpoint, *val.AppConfig)
if err != nil {