circleCI config and linting fixes (#3)

* Fixed circleci config and fixed linting warnings

* Updated circleCI for go version 1.12 and split jobs for build/testing

* updated go version to 1.12.5 for circleCI

* Go mod tidy dependencies

* Updated linting tools and cleared up code lint smells

* Added workflow to run build and test jobs

* Moved linting command to build workflow

* Get dependencies before linting by default

* Added go module flag to linter and increased deadline to pull packages

x/evm/types/codec.go

@@ -13,7 +13,7 @@ func init() {
 	msgCodec = cdc.Seal()
 }
 
-// Register concrete types and interfaces on the given codec.
+// RegisterCodec registers concrete types and interfaces on the given codec.
 func RegisterCodec(cdc *codec.Codec) {
 	cdc.RegisterConcrete(&EthereumTxMsg{}, "ethermint/MsgEthereumTx", nil)
 }

x/evm/types/journal.go

@@ -121,9 +121,9 @@ type (
 	}
 
 	touchChange struct {
-		account   *ethcmn.Address
-		prev      bool
-		prevDirty bool
+		account *ethcmn.Address
+		// prev      bool
+		// prevDirty bool
 	}
 )
 

x/evm/types/utils.go

@@ -12,7 +12,7 @@ import (
 	"github.com/pkg/errors"
 )
 
-// GenerateAddress generates an Ethereum address.
+// GenerateEthAddress generates an Ethereum address.
 func GenerateEthAddress() ethcmn.Address {
 	priv, err := crypto.GenerateKey()
 	if err != nil {
@@ -40,6 +40,7 @@ func ValidateSigner(signBytes, sig []byte, signer ethcmn.Address) error {
 func rlpHash(x interface{}) (hash ethcmn.Hash) {
 	hasher := ethsha.NewKeccak256()
 
+	// nolint:errcheck
 	rlp.Encode(hasher, x)
 	hasher.Sum(hash[:0])