From 5d237a5ee41454424f98cb11d5054d25bc44b3b7 Mon Sep 17 00:00:00 2001 From: Emmanuel T Odeke Date: Tue, 14 Dec 2021 18:05:11 -0800 Subject: [PATCH] fix: remove duplicated gasPrice derivation (#836) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Noticed in an audit, this change removes a duplicated gasPrice conversion that was first made in: https://github.com/tharsis/ethermint/blob/423944bf799816b6db214fabebcf1b334d3b0826/x/evm/types/tx_args.go#L76-L78 as well as in https://github.com/tharsis/ethermint/blob/423944bf799816b6db214fabebcf1b334d3b0826/x/evm/types/tx_args.go#L88-L90 Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> --- x/evm/types/tx_args.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/x/evm/types/tx_args.go b/x/evm/types/tx_args.go index 85ea7c0e..24e16f60 100644 --- a/x/evm/types/tx_args.go +++ b/x/evm/types/tx_args.go @@ -85,10 +85,6 @@ func (args *TransactionArgs) ToTransaction() *MsgEthereumTx { maxPriorityFeePerGas = sdk.NewIntFromBigInt(args.MaxPriorityFeePerGas.ToInt()) } - if args.GasPrice != nil { - gasPrice = sdk.NewIntFromBigInt(args.GasPrice.ToInt()) - } - if args.Value != nil { value = sdk.NewIntFromBigInt(args.Value.ToInt()) }