migrate build to Travis #258 (#259)

* add travis file
* update lint so it reports properly
* disable circleci
* separate test structure into Verify deps & Lint, Unit Tests, Race Tests, Integration Tests
* fix path issue now evident on ci build err
* fixed golangci version to latest stable
* Upgrade ci lint to go script and avoid cache issues #268
* fix lint issues #268
* bump go version for travis build to match go.mod version recently updated with Cosmos SDK upgrade
* add panic for err edge cases on os.Stat
* increase timeout to 10m since its failing on jenkins
* bump GOLANGCI_VERSION to 1.23.8 in order to try avoiding some weird errors on CI

x/evm/handler_test.go

@@ -122,10 +122,12 @@ func (suite *EvmTestSuite) TestHandleMsgEthereumTx() {
 	for _, tc := range testCases {
 		suite.Run("", func() {
 			suite.SetupTest() // reset
+			//nolint
 			tc.malleate()
 
 			res, err := suite.handler(suite.ctx, tx)
 
+			//nolint
 			if tc.expPass {
 				suite.Require().NoError(err)
 				suite.Require().NotNil(res)
@@ -176,10 +178,12 @@ func (suite *EvmTestSuite) TestMsgEthermint() {
 	for _, tc := range testCases {
 		suite.Run("", func() {
 			suite.SetupTest() // reset
+			//nolint
 			tc.malleate()
 
 			res, err := suite.handler(suite.ctx, tx)
 
+			//nolint
 			if tc.expPass {
 				suite.Require().NoError(err)
 				suite.Require().NotNil(res)

x/evm/keeper/querier_test.go

@@ -35,16 +35,21 @@ func (suite *KeeperTestSuite) TestQuerier() {
 
 	for i, tc := range testCases {
 		suite.Run("", func() {
+			//nolint
 			tc := tc
 			suite.SetupTest() // reset
+			//nolint
 			tc.malleate()
 
 			bz, err := suite.querier(suite.ctx, tc.path, abci.RequestQuery{})
 
+			//nolint
 			if tc.expPass {
+				//nolint
 				suite.Require().NoError(err, "valid test %d failed: %s", i, tc.msg)
 				suite.Require().NotZero(len(bz))
 			} else {
+				//nolint
 				suite.Require().Error(err, "invalid test %d passed: %s", i, tc.msg)
 			}
 		})

x/evm/types/msg.go

@@ -109,7 +109,6 @@ type MsgEthereumTx struct {
 	Data TxData
 
 	// caches
-	hash atomic.Value
 	size atomic.Value
 	from atomic.Value
 }

x/evm/types/msg_test.go

@@ -169,7 +169,8 @@ func TestMsgEthereumTxSig(t *testing.T) {
 
 	// require valid signature passes validation
 	msg := NewMsgEthereumTx(0, &addr1, nil, 100000, nil, []byte("test"))
-	msg.Sign(chainID, priv1.ToECDSA())
+	err := msg.Sign(chainID, priv1.ToECDSA())
+	require.Nil(t, err)
 
 	signer, err := msg.VerifySig(chainID)
 	require.NoError(t, err)
@@ -178,7 +179,8 @@ func TestMsgEthereumTxSig(t *testing.T) {
 
 	// require invalid chain ID fail validation
 	msg = NewMsgEthereumTx(0, &addr1, nil, 100000, nil, []byte("test"))
-	msg.Sign(chainID, priv1.ToECDSA())
+	err = msg.Sign(chainID, priv1.ToECDSA())
+	require.Nil(t, err)
 
 	signer, err = msg.VerifySig(big.NewInt(4))
 	require.Error(t, err)