From 4a66ff95d9f5cbaba8aacec44e69879de9c42e0e Mon Sep 17 00:00:00 2001 From: Daniel Burckhardt Date: Fri, 1 Jul 2022 13:55:19 +0200 Subject: [PATCH] feemarket(specs): add hint on different gas terminology for gas in Cosmos and Ethereum (#1165) --- CHANGELOG.md | 6 ++++++ Makefile | 2 +- x/feemarket/spec/01_concepts.md | 4 ++++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1bb1b502..640f2ce2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,12 @@ Ref: https://keepachangelog.com/en/1.0.0/ # Changelog +## Unreleased + +### Improvements + +* (feemarket) [\#1165](https://github.com/evmos/ethermint/pull/1165) Add hint in specs about different gas terminology for gas in Cosmos and Ethereum. + ## [v0.17.0] - 2022-06-27 ### State Machine Breaking diff --git a/Makefile b/Makefile index 2e1eeaa5..1f183ab7 100755 --- a/Makefile +++ b/Makefile @@ -154,7 +154,7 @@ build-all: tools build lint test ############################################################################### PACKAGE_NAME:=github.com/evmos/ethermint -GOLANG_CROSS_VERSION = v1.18 +GOLANG_CROSS_VERSION = v1.18 GOPATH ?= '$(HOME)/go' release-dry-run: docker run \ diff --git a/x/feemarket/spec/01_concepts.md b/x/feemarket/spec/01_concepts.md index 878ccf63..12071d7b 100644 --- a/x/feemarket/spec/01_concepts.md +++ b/x/feemarket/spec/01_concepts.md @@ -24,6 +24,10 @@ fee = (baseFee + priorityTip) * gasLimit , where `baseFee` is the fixed-per-block network fee per gas and `priorityTip` is an additional fee per gas that can be set optionally. Note, that both the base fee and the priority tip are a gas prices. To submit a transaction with EIP-1559, the signer needs to specify the `gasFeeCap` a maximum fee per gas they are willing to pay total and optionally the `priorityTip` , which covers both the priority fee and the block's network fee per gas (aka: base fee). +::: tip +The Cosmos SDK uses a different terminology for `gas` than Ethereum. What is called `gasLimit` on Ethereum is called `gasWanted` on Cosmos. You might encounter both terminologies on Evmos since it builds Ethereum on top of the SDK, e.g. when using different wallets like Keplr for Cosmos and Metamask for Ethereum. +::: + ## Base Fee The base fee per gas (aka base fee) is a global gas price defined at the consensus level. It is stored as a module parameter and is adjusted at the end of each block based on the total gas used in the previous block and gas target (`block gas limit / elasticity multiplier`):