replace CIDFromJSONBytes (#97)

* replace fn

* fix unit test CID

* rename func

utils/json.go

@@ -10,7 +10,6 @@ import (
 
 	canonicalJson "github.com/gibson042/canonicaljson-go"
 	"github.com/ipfs/go-cid"
-	cbor "github.com/ipfs/go-ipld-cbor"
 	"github.com/ipld/go-ipld-prime/codec/dagcbor"
 	"github.com/ipld/go-ipld-prime/codec/dagjson"
 	"github.com/ipld/go-ipld-prime/linking"
@@ -18,7 +17,6 @@ import (
 	"github.com/ipld/go-ipld-prime/multicodec"
 	basicnode "github.com/ipld/go-ipld-prime/node/basic"
 	"github.com/ipld/go-ipld-prime/storage/memstore"
-	mh "github.com/multiformats/go-multihash"
 )
 
 var store = memstore.Store{}
@@ -35,7 +33,7 @@ func GenerateHash(json map[string]interface{}) (string, []byte, error) {
 		return "", nil, err
 	}
 
-	cidString, err := CIDFromJSONBytesUsingIpldPrime(content)
+	cidString, err := CIDFromJSONBytes(content)
 	if err != nil {
 		return "", nil, err
 	}
@@ -43,16 +41,6 @@ func GenerateHash(json map[string]interface{}) (string, []byte, error) {
 	return cidString, content, nil
 }
 
-// CIDFromJSONBytes returns CID (cbor) for json (as bytes).
-func CIDFromJSONBytes(content []byte) (string, error) {
-	cid, err := cbor.FromJSON(bytes.NewReader(content), mh.SHA2_256, -1)
-	if err != nil {
-		return "", err
-	}
-
-	return cid.String(), nil
-}
-
 // GetAttributeAsString returns a map attribute as string, if possible.
 func GetAttributeAsString(obj map[string]interface{}, attr string) (string, error) {
 	if value, ok := obj[attr]; ok {
@@ -66,10 +54,14 @@ func GetAttributeAsString(obj map[string]interface{}, attr string) (string, erro
 	return "", errors.New("attribute not found")
 }
 
-// CIDFromJSONBytesUsingIpldPrime returns CID (dagcbor) for json (as bytes).
+// CIDFromJSONBytes returns CID (dagcbor) for json (as bytes).
 // This is combination of samples for unmarshalling and linking
 // see: https://pkg.go.dev/github.com/ipld/go-ipld-prime
-func CIDFromJSONBytesUsingIpldPrime(content []byte) (string, error) {
+func CIDFromJSONBytes(content []byte) (string, error) {
+	if len(content) == 0 {
+		return "", nil
+	}
+
 	np := basicnode.Prototype.Any                       // Pick a stle for the in-memory data.
 	nb := np.NewBuilder()                               // Create a builder.
 	err := dagjson.Decode(nb, bytes.NewReader(content)) // Hand the builder to decoding -- decoding will fill it in!

utils/json_test.go

@@ -1,8 +1,9 @@
 package utils
 
 import (
-	"github.com/stretchr/testify/require"
 	"testing"
+
+	"github.com/stretchr/testify/require"
 )
 
 func TestAndValidateCIDGeneration(t *testing.T) {
@@ -11,13 +12,12 @@ func TestAndValidateCIDGeneration(t *testing.T) {
 		content  string
 		expected string
 	}{
-		// empty string and empty json blows up
+		{
-		// {
+			"empty string", "", "",
-		//  	"empty string", "", "bafyreiengp2sbi6ez34a2jctv34bwyjl7yoliteleaswgcwtqzrhmpyt2m",
+		},
-		// },
+		{
-		// {
+			"empty json", "{}", "bafyreigbtj4x7ip5legnfznufuopl4sg4knzc2cof6duas4b3q2fy6swua",
-		//		"empty json", "{}", "bafyreihpfkdvib5muloxlj5b3tgdwibjdcu3zdsuhyft33z7gtgnlzlkpm",
+		},
-		// },
 
 		{
 			"test record", "{\"build_artifact_cid\":\"QmP8jTG1m9GSDJLCbeWhVSVgEzCPPwXRdCRuJtQ5Tz9Kc9\",\"repo_registration_record_cid\":\"QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D\",\"tls_cert_cid\":\"QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR\",\"type\":\"WebsiteRegistrationRecord\",\"url\":\"https://cerc.io\",\"version\":\"0.0.1\"}",
@@ -26,10 +26,8 @@ func TestAndValidateCIDGeneration(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		deprecatedAndCorrect, _ := CIDFromJSONBytes([]byte(tc.content))
+		newImpl, err := CIDFromJSONBytes([]byte(tc.content))
-		newImpl, err := CIDFromJSONBytesUsingIpldPrime([]byte(tc.content))
 		require.NoError(t, err)
-		require.Equal(t, deprecatedAndCorrect, newImpl, tc.name)
 		require.Equal(t, tc.expected, newImpl)
 	}
 }

x/registry/helpers/helpers.go

@@ -70,7 +70,7 @@ func UnMarshalMapFromJSONBytes(bytes []byte) map[string]interface{} {
 
 // GetCid gets the content ID.
 func GetCid(content []byte) (string, error) {
-	return wnsUtils.CIDFromJSONBytesUsingIpldPrime(content)
+	return wnsUtils.CIDFromJSONBytes(content)
 }
 
 // BytesToBase64 encodes a byte array as a base64 string.