Address PR reviews in regards to transaction sigs

This commit is contained in:
Aleksandr Bezobchuk 2018-08-22 09:53:27 -04:00
parent 63c160977b
commit 38c228cc1a

View File

@ -48,19 +48,19 @@ Cosmos SDK `sdk.Tx` interface.
## Signatures ## Signatures
Ethermint supports [EIP-155](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-155.md) Ethermint supports [EIP-155](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-155.md)
signatures. However, just as in Cosmos, Ethermint will support multiple signers. signatures. A `Transaction` is expected to have a single signature for Ethereum
A client is expected to sign the `Transaction` just as in Ethereum, however, the routed transactions. However, just as in Cosmos, Ethermint will support multiple
`EmbeddedTx` contains a canonical signature structure that itself contains the signers for `EmbeddedTx` Cosmos routed transactions. Signatures over the
signature and other information such as an account's sequence number. The sequence `Transaction` type are identical to Ethereum. However, the `EmbeddedTx` contains
number is expected to increment every time a message is signed by a given account. a canonical signature structure that contains the signature itself and other
This prevents "replay attacks", where the same message could be executed over and information such as an account's sequence number. The sequence number is expected
over again. to increment every time a message is signed by a given account. This, in addition
to the chain ID, prevents "replay attacks", where the same message could be
executed over and over again.
An `EmbeddedTx` list of signatures must much the unique list of addresses returned by An `EmbeddedTx` list of signatures must much the unique list of addresses returned
each message's `GetSigners` call. In addition, the address of first signer of the by each message's `GetSigners` call. In addition, the address of first signer of
`EmbeddedTx` is responsible for paying the fees and must also match the address of the `EmbeddedTx` is responsible for paying the fees.
the signer of the embedding `Transaction`. As such, there will be one duplicate
signature.
## Gas & Fees ## Gas & Fees