deep-stack/laconicd-deprecated
6
0
Fork 0
forked from cerc-io/laconicd-deprecated
Code Pull Requests Activity

fix: return nil response for gql queries

Browse Source
This commit is contained in:
nabarun 2022-04-08 18:02:18 +05:30
parent 555934b799
commit 2b8b18d659
1 changed files with 15 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
gql/resolver.go
View File

@ -78,9 +78,8 @@ func (q queryResolver) ResolveNames(ctx context.Context, names []string) ([]*Rec
for _, name := range names { for _, name := range names {
res, err := nsQueryClient.ResolveWrn(context.Background(), &nstypes.QueryResolveWrn{Wrn: name}) res, err := nsQueryClient.ResolveWrn(context.Background(), &nstypes.QueryResolveWrn{Wrn: name})
if err != nil { if err != nil {
return nil, err gqlResponse = append(gqlResponse, nil)
} } else {
gqlRecord, err := getGQLRecord(context.Background(), q, *res.GetRecord()) gqlRecord, err := getGQLRecord(context.Background(), q, *res.GetRecord())
if err != nil { if err != nil {
return nil, err return nil, err
@ -88,6 +87,7 @@ func (q queryResolver) ResolveNames(ctx context.Context, names []string) ([]*Rec
gqlResponse = append(gqlResponse, gqlRecord) gqlResponse = append(gqlResponse, gqlRecord)
} }
}
return gqlResponse, nil return gqlResponse, nil
} }
@ -99,9 +99,9 @@ func (q queryResolver) LookupNames(ctx context.Context, names []string) ([]*Name
for _, name := range names { for _, name := range names {
res, err := nsQueryClient.LookupWrn(context.Background(), &nstypes.QueryLookupWrn{Wrn: name}) res, err := nsQueryClient.LookupWrn(context.Background(), &nstypes.QueryLookupWrn{Wrn: name})
if err != nil { if err != nil {
return nil, err // Instead of throwing error for name not found, return nil similar to https://github.com/vulcanize/dxns/blob/main/gql/resolver.go#L191
} gqlResponse = append(gqlResponse, nil)
} else {
gqlRecord, err := getGQLNameRecord(res.GetName()) gqlRecord, err := getGQLNameRecord(res.GetName())
if err != nil { if err != nil {
return nil, err return nil, err
@ -109,6 +109,7 @@ func (q queryResolver) LookupNames(ctx context.Context, names []string) ([]*Name
gqlResponse = append(gqlResponse, gqlRecord) gqlResponse = append(gqlResponse, gqlRecord)
} }
}
return gqlResponse, nil return gqlResponse, nil
} }