eth_sendTransaction returns internal trace on missing param (#1284)

* added test, used get method for from param

* gosec fixes

* adding nosec v1

* added test to python tests, removed testing lines

* fixing flake issues

* test-unit-cover

* changelog fix

* changelog 2

* fix gomod2nix

* integration tests

Co-authored-by: Freddy Caceres <facs95@gmail.com>

tests/integration_tests/test_types.py

@@ -323,6 +323,15 @@ def make_same_rpc_calls(rpc1, rpc2, method, params):
     assert res, err
 
 
+def test_incomplete_send_transaction(ethermint, geth):
+    # Send ethereum tx with nothing in from field
+    eth_rpc = ethermint.w3.provider
+    geth_rpc = geth.w3.provider
+    gas_price = ethermint.w3.eth.gas_price
+    tx = {"from": "", "to": ADDRS["community"], "value": 0, "gasPrice": gas_price}
+    make_same_rpc_calls(eth_rpc, geth_rpc, "eth_sendTransaction", [tx])
+
+
 def same_types(object_a, object_b):
 
     if isinstance(object_a, dict):

tests/rpc/rpc_test.go

@@ -329,6 +329,24 @@ func waitForReceipt(t *testing.T, hash hexutil.Bytes) map[string]interface{} {
 	}
 }
 
+func TestEth_IncompleteSendTransaction(t *testing.T) {
+	// get gasprice
+	gasPrice := GetGasPrice(t)
+
+	// make tx params without from address
+	param := make([]map[string]string, 1)
+	param[0] = make(map[string]string)
+	param[0]["from"] = ""
+	param[0]["to"] = "0x1122334455667788990011223344556677889900"
+	param[0]["value"] = "0x1"
+	param[0]["gasPrice"] = gasPrice
+	_, err := callWithError("eth_sendTransaction", param)
+
+	// require well-formatted error (should not be "method handler crashed")
+	require.Error(t, err)
+	require.NotEqual(t, err.Error(), "method handler crashed", "no from field dealt with incorrectly")
+}
+
 func TestEth_GetFilterChanges_NoTopics(t *testing.T) {
 	rpcRes := call(t, "eth_blockNumber", []string{})