laconicd-deprecated/.github/PULL_REQUEST_TEMPLATE.md

21 lines
972 B
Markdown
Raw Normal View History

2018-08-01 12:35:42 +00:00
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺
2018-07-09 19:47:49 +00:00
v ✰ Thanks for creating a PR! ✰
2018-08-01 12:35:42 +00:00
v Before smashing the submit button please review the checkboxes.
2018-07-09 19:47:49 +00:00
v If a checkbox is n/a - please still include it but + a little note why
2018-08-01 12:35:42 +00:00
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->
2018-07-09 19:47:49 +00:00
2018-09-06 18:54:17 +00:00
- Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ethermint/blob/master/CONTRIBUTING.md#pr-targeting))
2018-08-01 12:35:42 +00:00
- [ ] Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Wrote tests
2018-09-06 18:54:17 +00:00
- [ ] Updated relevant documentation (`docs/`)
- [ ] Added entries in `PENDING.md` with issue #
- [ ] rereviewed `Files changed` in the github PR explorer
______
2018-08-01 12:35:42 +00:00
For Admin Use:
2018-09-06 18:54:17 +00:00
- Added appropriate labels to PR (ex. wip, ready-for-review, docs)
- Reviewers Assigned
- Squashed all commits, uses message "Merge pull request #XYZ: [title]"