From d68f173917e99ba92a54955ea56d5e4a3e125b49 Mon Sep 17 00:00:00 2001 From: Haoyun Date: Tue, 3 Apr 2018 16:21:28 +0800 Subject: [PATCH 1/3] typo fix typo fix --- pkg/transformer/openshift/openshift.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/transformer/openshift/openshift.go b/pkg/transformer/openshift/openshift.go index 7867c4aa..7d0b3983 100644 --- a/pkg/transformer/openshift/openshift.go +++ b/pkg/transformer/openshift/openshift.go @@ -72,7 +72,7 @@ const TIMEOUT = 300 // by keeping record if already saw this key in another service var unsupportedKey = map[string]bool{} -// initImageStream initialize ImageStream object +// initImageStream initializes ImageStream object func (o *OpenShift) initImageStream(name string, service kobject.ServiceConfig, opt kobject.ConvertOptions) *imageapi.ImageStream { // Retrieve tags and image name for mapping @@ -171,7 +171,7 @@ func initBuildConfig(name string, service kobject.ServiceConfig, repo string, br return bc, nil } -// initDeploymentConfig initialize OpenShifts DeploymentConfig object +// initDeploymentConfig initializes OpenShifts DeploymentConfig object func (o *OpenShift) initDeploymentConfig(name string, service kobject.ServiceConfig, replicas int) *deployapi.DeploymentConfig { containerName := []string{name} From d0298071459d8e35fb2ed7827adaa841c4406e51 Mon Sep 17 00:00:00 2001 From: Haoyun Date: Tue, 3 Apr 2018 16:31:31 +0800 Subject: [PATCH 2/3] typo fix typo fix --- pkg/utils/docker/push.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/utils/docker/push.go b/pkg/utils/docker/push.go index 106a8709..c1a3af9c 100644 --- a/pkg/utils/docker/push.go +++ b/pkg/utils/docker/push.go @@ -30,7 +30,7 @@ type Push struct { } /* -PushImage push a Docker image via the Docker API. Takes the image name, +PushImage pushes a Docker image via the Docker API. Takes the image name, parses the URL details and then push based on environment authentication credentials. */ From 077ef90e0109d4cf64f3ba9b81e8ec4222bd9337 Mon Sep 17 00:00:00 2001 From: Haoyun Date: Tue, 3 Apr 2018 17:12:30 +0800 Subject: [PATCH 3/3] typo fix typo fix --- pkg/transformer/kubernetes/kubernetes.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/transformer/kubernetes/kubernetes.go b/pkg/transformer/kubernetes/kubernetes.go index ba902740..24535a36 100644 --- a/pkg/transformer/kubernetes/kubernetes.go +++ b/pkg/transformer/kubernetes/kubernetes.go @@ -159,7 +159,7 @@ func (k *Kubernetes) InitSvc(name string, service kobject.ServiceConfig) *api.Se return svc } -// InitConfigMap initialized a ConfigMap object +// InitConfigMap initializes a ConfigMap object func (k *Kubernetes) InitConfigMap(name string, service kobject.ServiceConfig, opt kobject.ConvertOptions, envFile string) *api.ConfigMap { envs, err := GetEnvsFromFile(envFile, opt)