From c7d6bc63d9c614717975af145a7a5c803d1278f1 Mon Sep 17 00:00:00 2001 From: Suraj Narwade Date: Wed, 11 Oct 2017 12:54:42 +0530 Subject: [PATCH] Added support for build key in v3 Resolves #636 This PR will add support for `build` in docker compose v3. As https://github.com/docker/cli/pull/481 got merged now --- pkg/loader/compose/v3.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/loader/compose/v3.go b/pkg/loader/compose/v3.go index 55288156..8e239bf9 100644 --- a/pkg/loader/compose/v3.go +++ b/pkg/loader/compose/v3.go @@ -311,8 +311,9 @@ func dockerComposeToKomposeMapping(composeObject *types.Config) (kobject.Kompose // TODO: Build is not yet supported, see: // https://github.com/docker/cli/blob/master/cli/compose/types/types.go#L9 // We will have to *manually* add this / parse. - // serviceConfig.Build = composeServiceConfig.Build.Context - // serviceConfig.Dockerfile = composeServiceConfig.Build.Dockerfile + serviceConfig.Build = composeServiceConfig.Build.Context + serviceConfig.Dockerfile = composeServiceConfig.Build.Dockerfile + serviceConfig.BuildArgs = composeServiceConfig.Build.Args // Gather the environment values // DockerCompose uses map[string]*string while we use []string