diff --git a/pkg/transformer/kubernetes/k8sutils.go b/pkg/transformer/kubernetes/k8sutils.go index ba421f5d..34482f1f 100644 --- a/pkg/transformer/kubernetes/k8sutils.go +++ b/pkg/transformer/kubernetes/k8sutils.go @@ -213,3 +213,12 @@ func convertToVersion(objs []runtime.Object) ([]runtime.Object, error) { return ret, nil } + +func PortsExist(name string, service kobject.ServiceConfig) bool { + if len(service.Port) == 0 { + logrus.Warningf("[%s] Service cannot be created because of missing port.", name) + return false + } else { + return true + } +} diff --git a/pkg/transformer/kubernetes/kubernetes.go b/pkg/transformer/kubernetes/kubernetes.go index 677cb262..ddf8b13d 100644 --- a/pkg/transformer/kubernetes/kubernetes.go +++ b/pkg/transformer/kubernetes/kubernetes.go @@ -314,11 +314,10 @@ func (k *Kubernetes) Transform(komposeObject kobject.KomposeObject, opt kobject. } // If ports not provided in configuration we will not make service - if len(ports) == 0 { - logrus.Warningf("[%s] Service cannot be created because of missing port.", name) - } else { + if PortsExist(name, service) { objects = append(objects, sc) } + allobjects = append(allobjects, objects...) } diff --git a/pkg/transformer/openshift/openshift.go b/pkg/transformer/openshift/openshift.go index aa21fa09..ec805beb 100644 --- a/pkg/transformer/openshift/openshift.go +++ b/pkg/transformer/openshift/openshift.go @@ -153,9 +153,7 @@ func (k *OpenShift) Transform(komposeObject kobject.KomposeObject, opt kobject.C } // If ports not provided in configuration we will not make service - if len(ports) == 0 { - logrus.Warningf("[%s] Service cannot be created because of missing port.", name) - } else { + if kubernetes.PortsExist(name, service) { objects = append(objects, sc) } allobjects = append(allobjects, objects...)