From 4d4ff4e3948c5beddf278af0c249274b2aa8adbc Mon Sep 17 00:00:00 2001 From: Tomer Zait Date: Sun, 4 Feb 2024 12:07:05 +0200 Subject: [PATCH] fix client/convert (issue https://github.com/kubernetes/kompose/issues/1818) --- client/convert.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/convert.go b/client/convert.go index c56122b2..55d95d15 100644 --- a/client/convert.go +++ b/client/convert.go @@ -64,7 +64,7 @@ func (k *Kompose) setDefaultValues(options ConvertOptions) ConvertOptions { buildDefaultValue := "none" volumeTypeDefaultValue := "persistentVolumeClaim" withKomposeAnnotationsDefaultValue := true - kubernetesControllerDefaultValue := "deployment" + kubernetesControllerDefaultValue := "" kubernetesServiceGroupModeDefaultValue := "" if options.Replicas == nil { @@ -126,7 +126,7 @@ func (k *Kompose) validateOptions(options ConvertOptions) error { if kubernetesProvider, ok := options.Provider.(Kubernetes); ok { kubernetesController := kubernetesProvider.Controller - if *kubernetesController != string(DEPLOYMENT) && *kubernetesController != string(DAEMONSET) && *kubernetesController != string(REPLICATION_CONTROLLER) { + if *kubernetesController != "" && *kubernetesController != string(DEPLOYMENT) && *kubernetesController != string(DAEMONSET) && *kubernetesController != string(REPLICATION_CONTROLLER) { return fmt.Errorf( "unexpected Value for Kubernetes Controller field. Possible values are: %v, %v, and %v", string(DEPLOYMENT), string(DAEMONSET), string(REPLICATION_CONTROLLER), )