From e0bcd324d5b6e681885bf67ffd7309c50d3b5868 Mon Sep 17 00:00:00 2001 From: Suraj Deshmukh Date: Wed, 27 Jul 2016 10:25:02 +0000 Subject: [PATCH] Warning on missing port information and no service created Now when user will not provide any port information a warning will be shown and also service will not be created. Fixes #58 --- cli/app/app.go | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/cli/app/app.go b/cli/app/app.go index 04685f0c..f64cdcf2 100644 --- a/cli/app/app.go +++ b/cli/app/app.go @@ -932,10 +932,16 @@ func komposeConvert(komposeObject KomposeObject, opt convertOptions) { logrus.Fatalf(err.Error()) } - // convert datasvc to json / yaml - datasvc, err := transformer(sc, opt.generateYaml) - if err != nil { - logrus.Fatalf(err.Error()) + var datasvc []byte + // If ports not provided in configuration we will not make service + if len(ports) == 0 { + logrus.Warningf("[%s] Service cannot be created because of missing port.", name) + } else { + // convert datasvc to json / yaml + datasvc, err = transformer(sc, opt.generateYaml) + if err != nil { + logrus.Fatalf(err.Error()) + } } // convert OpenShift DeploymentConfig to json / yaml