From 771e564645e601339f30ffeb98a03a2c3cd4e402 Mon Sep 17 00:00:00 2001
From: AhmedGrati <ahmedgrati1999@gmail.com>
Date: Tue, 31 Oct 2023 23:51:10 +0100
Subject: [PATCH] test: add unit-tests for FormatEnvName function

Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
---
 pkg/transformer/kubernetes/k8sutils.go      |  2 +-
 pkg/transformer/kubernetes/k8sutils_test.go | 47 +++++++++++++++++++++
 2 files changed, 48 insertions(+), 1 deletion(-)

diff --git a/pkg/transformer/kubernetes/k8sutils.go b/pkg/transformer/kubernetes/k8sutils.go
index 6241dea0..439d61f8 100644
--- a/pkg/transformer/kubernetes/k8sutils.go
+++ b/pkg/transformer/kubernetes/k8sutils.go
@@ -857,7 +857,7 @@ func FormatEnvName(name string) string {
 	if strings.Contains(envName, "/") {
 		envName = envName[strings.LastIndex(envName, "/")+1:]
 	}
-	// take only last 63 chars
+	// take only last chars: The ones after 63th index
 	if len(envName) > 63 {
 		envName = envName[len(envName)-63:]
 	}
diff --git a/pkg/transformer/kubernetes/k8sutils_test.go b/pkg/transformer/kubernetes/k8sutils_test.go
index d050a610..a2bf5493 100644
--- a/pkg/transformer/kubernetes/k8sutils_test.go
+++ b/pkg/transformer/kubernetes/k8sutils_test.go
@@ -657,3 +657,50 @@ func TestReadOnlyRootFS(t *testing.T) {
 		}
 	}
 }
+
+func TestFormatEnvName(t *testing.T) {
+	type args struct {
+		name string
+	}
+	tests := []struct {
+		name string
+		args args
+		want string
+	}{
+		{
+			name: "check dot conversion",
+			args: args{
+				name: "random.test",
+			},
+			want: "random-test",
+		},
+		{
+			name: "check that path is shortened",
+			args: args{
+				name: "random/test/v1",
+			},
+			want: "v1",
+		},
+		{
+			name: "check that ./ is removed",
+			args: args{
+				name: "./random",
+			},
+			want: "random",
+		},
+		{
+			name: "check that ./ is removed",
+			args: args{
+				name: "abcdefghijklnmopqrstuvxyzabcdefghijklmnopqrstuvwxyzabcdejghijkl$Hereisadditional",
+			},
+			want: "rstuvxyzabcdefghijklmnopqrstuvwxyzabcdejghijkl$Hereisadditional",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := FormatEnvName(tt.args.name); got != tt.want {
+				t.Errorf("FormatEnvName() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}