forked from LaconicNetwork/kompose
add stdin_open, tty support, add tests, fix #344
This adds supports for stdin_open: bool and tty: bool support for kubernetes and openshift providers in kompose. This maps to the template.Spec.Containers[0].Stdin and template.Spec.Containers[0].TTY in Kubernets world. Also, added tests. Fixes #344
This commit is contained in:
@@ -324,6 +324,8 @@ func (k *Kubernetes) UpdateKubernetesObjects(name string, service kobject.Servic
|
||||
template.Spec.Containers[0].Args = service.Args
|
||||
template.Spec.Containers[0].WorkingDir = service.WorkingDir
|
||||
template.Spec.Containers[0].VolumeMounts = volumesMount
|
||||
template.Spec.Containers[0].Stdin = service.Stdin
|
||||
template.Spec.Containers[0].TTY = service.Tty
|
||||
template.Spec.Volumes = volumes
|
||||
|
||||
securityContext := &api.SecurityContext{}
|
||||
|
||||
@@ -53,6 +53,8 @@ func newServiceConfig() kobject.ServiceConfig {
|
||||
Privileged: true,
|
||||
Restart: "always",
|
||||
User: "user", // not supported
|
||||
Stdin: true,
|
||||
Tty: true,
|
||||
}
|
||||
}
|
||||
|
||||
@@ -168,6 +170,12 @@ func checkPodTemplate(config kobject.ServiceConfig, template api.PodTemplateSpec
|
||||
if config.Privileged == privilegedNilOrFalse(template) {
|
||||
return fmt.Errorf("Found different template privileged: %#v vs. %#v", config.Privileged, template.Spec.Containers[0].SecurityContext)
|
||||
}
|
||||
if config.Stdin != template.Spec.Containers[0].Stdin {
|
||||
return fmt.Errorf("Found different values for stdin: %#v vs. %#v", config.Stdin, template.Spec.Containers[0].Stdin)
|
||||
}
|
||||
if config.Tty != template.Spec.Containers[0].TTY {
|
||||
return fmt.Errorf("Found different values for TTY: %#v vs. %#v", config.Tty, template.Spec.Containers[0].TTY)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user