From 44f94cc072dbc96aa75c2fdf694f9bfd60d1e896 Mon Sep 17 00:00:00 2001
From: Ratnadeep Debnath <rtnpro@gmail.com>
Date: Mon, 26 Dec 2016 17:34:19 +0530
Subject: [PATCH] Fixes/updates based on review.

---
 pkg/testutils/git.go                        | 8 ++++----
 pkg/transformer/openshift/openshift_test.go | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/pkg/testutils/git.go b/pkg/testutils/git.go
index 158f9932..33316402 100644
--- a/pkg/testutils/git.go
+++ b/pkg/testutils/git.go
@@ -29,18 +29,18 @@ func CreateLocalGitDirectory(t *testing.T) string {
 	cmd.Dir = dir
 	_, err := cmd.Output()
 	if err != nil {
-		fmt.Println("create local git dir", err)
+		t.Logf("create local git dir: %v", err)
 		t.Fatal(err)
 	}
 	return dir
 }
 
 func SetGitRemote(t *testing.T, dir string, remote string, remoteUrl string) {
-	cmd := NewCommand("git remote add newremote https://git.test.com/somerepo")
+	cmd := NewCommand(fmt.Sprintf("git remote add %s %s", remote, remoteUrl))
 	cmd.Dir = dir
 	_, err := cmd.Output()
 	if err != nil {
-		fmt.Println("set git remote", err)
+		t.Logf("set git remote: %v", err)
 		t.Fatal(err)
 	}
 }
@@ -55,7 +55,7 @@ func CreateGitRemoteBranch(t *testing.T, dir string, branch string, remote strin
 
 	_, err := cmd.Output()
 	if err != nil {
-		fmt.Println("create git branch", err)
+		t.Logf("create git branch: %v", err)
 		t.Fatal(err)
 	}
 }
diff --git a/pkg/transformer/openshift/openshift_test.go b/pkg/transformer/openshift/openshift_test.go
index 6b9e5720..322863ea 100644
--- a/pkg/transformer/openshift/openshift_test.go
+++ b/pkg/transformer/openshift/openshift_test.go
@@ -194,7 +194,7 @@ func TestGitGetCurrentBranch(t *testing.T) {
 
 		if test.expectError {
 			if err == nil {
-				t.Errorf("Expected error, got success instead!")
+				t.Error("Expected error, got success instead!")
 			}
 		} else {
 			if err != nil {