From 6addbe51614c44095919bf75cfbdd3f039179ff7 Mon Sep 17 00:00:00 2001 From: zeromake Date: Fri, 6 Aug 2021 13:00:29 +0800 Subject: [PATCH 1/2] fix: --build flag default change to local --- cmd/convert.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/convert.go b/cmd/convert.go index 21cc3d88..385e36d0 100644 --- a/cmd/convert.go +++ b/cmd/convert.go @@ -143,7 +143,7 @@ func init() { convertCmd.Flags().MarkHidden("build-branch") // Standard between the two - convertCmd.Flags().StringVar(&ConvertBuild, "build", "none", `Set the type of build ("local"|"build-config"(OpenShift only)|"none")`) + convertCmd.Flags().StringVar(&ConvertBuild, "build", "local", `Set the type of build ("local"|"build-config"(OpenShift only)|"none")`) convertCmd.Flags().BoolVar(&ConvertPushImage, "push-image", true, "If we should push the docker image we built") convertCmd.Flags().BoolVarP(&ConvertYaml, "yaml", "y", false, "Generate resource files into YAML format") convertCmd.Flags().MarkDeprecated("yaml", "YAML is the default format now.") From bd52469d339a82251fcc814a8687ba8cff72e6bb Mon Sep 17 00:00:00 2001 From: zeromake Date: Fri, 6 Aug 2021 13:42:44 +0800 Subject: [PATCH 2/2] fix: revert --build flag, change push-image default is false --- cmd/convert.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/convert.go b/cmd/convert.go index 385e36d0..a4f11608 100644 --- a/cmd/convert.go +++ b/cmd/convert.go @@ -143,8 +143,8 @@ func init() { convertCmd.Flags().MarkHidden("build-branch") // Standard between the two - convertCmd.Flags().StringVar(&ConvertBuild, "build", "local", `Set the type of build ("local"|"build-config"(OpenShift only)|"none")`) - convertCmd.Flags().BoolVar(&ConvertPushImage, "push-image", true, "If we should push the docker image we built") + convertCmd.Flags().StringVar(&ConvertBuild, "build", "none", `Set the type of build ("local"|"build-config"(OpenShift only)|"none")`) + convertCmd.Flags().BoolVar(&ConvertPushImage, "push-image", false, "If we should push the docker image we built") convertCmd.Flags().BoolVarP(&ConvertYaml, "yaml", "y", false, "Generate resource files into YAML format") convertCmd.Flags().MarkDeprecated("yaml", "YAML is the default format now.") convertCmd.Flags().MarkShorthandDeprecated("y", "YAML is the default format now.")