deep-stack/kompose
4
0
Fork 0
forked from LaconicNetwork/kompose
Code Pull Requests Activity

Failing when port is specified with labels

Browse Source 
Resolves #522
Kompose will give FATAL error if labels are given but ports are not defined
This commit is contained in:
Suraj Narwade
2017-06-15 09:30:01 +05:30
parent 49ada134ae
commit 209cda28d2
5 changed files with 47 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/user-guide.md
+2 -1
View File
@@ -367,6 +367,7 @@ The currently supported options are:
| kompose.service.type | nodeport / clusterip / loadbalancer |
| kompose.service.expose| true / hostname |
**Note**: `kompose.service.type` label should be defined with `ports` only, otherwise `kompose` will fail.
## Restart
@@ -400,4 +401,4 @@ If the Docker Compose file has a volume specified for a service, the Deployment
If the Docker Compose file has service name with `_` in it (eg.`web_service`), then it will be replaced by `-` and the service name will be renamed accordingly (eg.`web-service`). Kompose does this because "Kubernetes" doesn't allow `_` in object name.
Please note that changing service name might break some `docker-compose` files.
Please note that changing service name might break some `docker-compose` files.