From 3411f3c94b697e3fe197c091e754acd2eead3fb1 Mon Sep 17 00:00:00 2001 From: Tomas Kral Date: Fri, 17 Mar 2017 17:09:49 +0100 Subject: [PATCH] do not fail if there is a golint violation golint output is just suggestion. Just show ouptut, but don't fail. This also remove unnecessary bash script that is no longer needed. --- Makefile | 2 +- script/check-lint.sh | 36 ------------------------------------ 2 files changed, 1 insertion(+), 37 deletions(-) delete mode 100755 script/check-lint.sh diff --git a/Makefile b/Makefile index 1a1d2f10..d31c8d68 100644 --- a/Makefile +++ b/Makefile @@ -70,7 +70,7 @@ vet: .PHONY: lint lint: - ./script/check-lint.sh + golint $(PKGS) .PHONY: gofmt gofmt: diff --git a/script/check-lint.sh b/script/check-lint.sh deleted file mode 100755 index d6123933..00000000 --- a/script/check-lint.sh +++ /dev/null @@ -1,36 +0,0 @@ -#!/bin/bash -set -e - -# Copyright 2016 The Kubernetes Authors All rights reserved. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - - -for pkg in $(glide novendor); do - lintOutput=$(golint "$pkg") - # if lineOutput is not empty, save it to errros array - if [ "$lintOutput" ]; then - errors+=("$lintOutput") - fi -done - - -if [ ${#errors[@]} -eq 0 ]; then - echo "golint OK" -else - echo "golint ERRORS:" - for err in "${errors[@]}"; do - echo "$err" - done - exit 1 -fi \ No newline at end of file