Add cast error checking to refactored transformers

This commit is contained in:
Edvard
2018-10-23 10:47:01 +02:00
parent b7f8432e65
commit cb74cbe990
26 changed files with 210 additions and 43 deletions
+7 -2
View File
@@ -15,6 +15,7 @@
package vat_move
import (
"fmt"
"github.com/vulcanize/vulcanizedb/pkg/core"
"github.com/vulcanize/vulcanizedb/pkg/datastore/postgres"
)
@@ -29,9 +30,13 @@ func (repository VatMoveRepository) Create(headerID int64, models []interface{})
return err
}
var vatMove VatMoveModel
for _, model := range models {
vatMove = model.(VatMoveModel)
vatMove, ok := model.(VatMoveModel)
if !ok {
tx.Rollback()
return fmt.Errorf("model of type %T, not %T", model, VatMoveModel{})
}
_, err = tx.Exec(
`INSERT INTO maker.vat_move (header_id, src, dst, rad, tx_idx, raw_log)
VALUES ($1, $2, $3, $4::NUMERIC, $5, $6)`,
+6 -1
View File
@@ -16,7 +16,6 @@ package vat_move_test
import (
"database/sql"
. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"
@@ -85,6 +84,12 @@ var _ = Describe("Vat Move", func() {
Expect(err).To(HaveOccurred())
Expect(err).To(MatchError(sql.ErrNoRows))
})
It("Returns an error if model is of wrong type", func() {
err = vatMoveRepository.Create(headerID, []interface{}{test_data.WrongModel{}})
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("model of type"))
})
})
Describe("MissingHeaders", func() {