Merge pull request #33 from vulcanize/redsquirrel-patch-2

Minor Solidity suggestion
This commit is contained in:
Rob Mulholand 2019-03-08 10:56:20 -06:00 committed by GitHub
commit c5862299e6

View File

@ -26,7 +26,7 @@ contract Contract {
function add_address(address addr) public { function add_address(address addr) public {
bool exists = addresses[addr] > 0; bool exists = addresses[addr] > 0;
addresses[addr] = addresses[addr] + 1; addresses[addr]++;
if (!exists) { if (!exists) {
emit AddressAdded(addr, ++num_addresses); emit AddressAdded(addr, ++num_addresses);
} }
@ -164,4 +164,4 @@ The mappings would be able to lookup storage keys reflecting `num_addresses` or
The repository would be able to persist the value or `num_addresses` or any slot in `addresses`, using metadata returned from the mappings. The repository would be able to persist the value or `num_addresses` or any slot in `addresses`, using metadata returned from the mappings.
The mappings and repository could be plugged into the common storage transformer, enabling us to know the contract's state as it is changing. The mappings and repository could be plugged into the common storage transformer, enabling us to know the contract's state as it is changing.