From 83593cb5f23e60bfed848648e26f77173f356c3a Mon Sep 17 00:00:00 2001 From: Edvard Date: Mon, 10 Dec 2018 21:12:55 +0100 Subject: [PATCH] Cleanup fetcher and add test todos --- pkg/transformers/shared/log_fetcher.go | 11 ----------- pkg/transformers/shared/log_fetcher_test.go | 7 +++++++ 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/pkg/transformers/shared/log_fetcher.go b/pkg/transformers/shared/log_fetcher.go index 47f6f77d..9d0e9415 100644 --- a/pkg/transformers/shared/log_fetcher.go +++ b/pkg/transformers/shared/log_fetcher.go @@ -22,25 +22,14 @@ import ( "github.com/vulcanize/vulcanizedb/pkg/core" ) -// TODO Check if Fetcher can be simplified with aggregate logic - type LogFetcher interface { FetchLogs(contractAddresses []common.Address, topics []common.Hash, missingHeader core.Header) ([]types.Log, error) } -type SettableLogFetcher interface { - LogFetcher - SetBC(bc core.BlockChain) -} - type Fetcher struct { blockChain core.BlockChain } -func (fetcher *Fetcher) SetBC(bc core.BlockChain) { - fetcher.blockChain = bc -} - func NewFetcher(blockchain core.BlockChain) Fetcher { return Fetcher{ blockChain: blockchain, diff --git a/pkg/transformers/shared/log_fetcher_test.go b/pkg/transformers/shared/log_fetcher_test.go index 4a0c55fa..73deb656 100644 --- a/pkg/transformers/shared/log_fetcher_test.go +++ b/pkg/transformers/shared/log_fetcher_test.go @@ -26,7 +26,14 @@ import ( ) var _ = Describe("Fetcher", func() { + Describe("Iinitialisation", func() { + It("creates correct lookup maps", func() { + + }) + }) + Describe("FetchLogs", func() { + // TODO Add tests for aggregate fetching It("fetches logs based on the given query", func() { blockChain := fakes.NewMockBlockChain() fetcher := shared.NewFetcher(blockChain)