rebase; extract factories and the mocks they are dependent on to

libraries/shared; adjust omni test_helpers to drop and recreate
checked_headers table to avoid reaching 1600 column limit after repeated
tests (dropping columns doesn't actually remove them from contributing
to that limit)

libraries/shared/repository/repository.go

@@ -27,30 +27,6 @@ import (
 	"github.com/vulcanize/vulcanizedb/pkg/datastore/postgres"
 )
 
-func GetOrCreateIlk(ilk string, db *postgres.DB) (int, error) {
-	var ilkID int
-	err := db.Get(&ilkID, `SELECT id FROM maker.ilks WHERE ilk = $1`, ilk)
-	if err != nil {
-		if err == sql.ErrNoRows {
-			insertErr := db.QueryRow(`INSERT INTO maker.ilks (ilk) VALUES ($1) RETURNING id`, ilk).Scan(&ilkID)
-			return ilkID, insertErr
-		}
-	}
-	return ilkID, err
-}
-
-func GetOrCreateIlkInTransaction(ilk string, tx *sql.Tx) (int, error) {
-	var ilkID int
-	err := tx.QueryRow(`SELECT id FROM maker.ilks WHERE ilk = $1`, ilk).Scan(&ilkID)
-	if err != nil {
-		if err == sql.ErrNoRows {
-			insertErr := tx.QueryRow(`INSERT INTO maker.ilks (ilk) VALUES ($1) RETURNING id`, ilk).Scan(&ilkID)
-			return ilkID, insertErr
-		}
-	}
-	return ilkID, err
-}
-
 func MarkHeaderChecked(headerID int64, db *postgres.DB, checkedHeadersColumn string) error {
 	_, err := db.Exec(`INSERT INTO public.checked_headers (header_id, `+checkedHeadersColumn+`)
 		VALUES ($1, $2)

libraries/shared/repository/repository_suite_test.go

@@ -0,0 +1,35 @@
+// VulcanizeDB
+// Copyright © 2018 Vulcanize
+
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU Affero General Public License for more details.
+
+// You should have received a copy of the GNU Affero General Public License
+// along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+package repository_test
+
+import (
+	"testing"
+
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+	log "github.com/sirupsen/logrus"
+	"io/ioutil"
+)
+
+func TestFactories(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "Shared Repository Suite")
+}
+
+var _ = BeforeSuite(func() {
+	log.SetOutput(ioutil.Discard)
+})

libraries/shared/repository/repository_utility_test.go

@@ -30,6 +30,7 @@ import (
 	"github.com/vulcanize/vulcanizedb/pkg/datastore/postgres"
 	"github.com/vulcanize/vulcanizedb/pkg/datastore/postgres/repositories"
 	"github.com/vulcanize/vulcanizedb/pkg/fakes"
+	r2 "github.com/vulcanize/vulcanizedb/pkg/omni/light/repository"
 	"github.com/vulcanize/vulcanizedb/test_config"
 )
 
@@ -45,12 +46,15 @@ var _ = Describe("Repository utilities", func() {
 			headerIDs                []int64
 			notCheckedSQL            string
 			err                      error
+			hr                       r2.HeaderRepository
 		)
 
 		BeforeEach(func() {
 			db = test_config.NewTestDB(test_config.NewTestNode())
 			test_config.CleanTestDB(db)
 			headerRepository = repositories.NewHeaderRepository(db)
+			hr = r2.NewHeaderRepository(db)
+			hr.AddCheckColumns(getExpectedColumnNames())
 
 			columnNames, err := shared.GetCheckedColumnNames(db)
 			Expect(err).NotTo(HaveOccurred())
@@ -71,6 +75,10 @@ var _ = Describe("Repository utilities", func() {
 			}
 		})
 
+		AfterEach(func() {
+			test_config.CleanCheckedHeadersTable(db, getExpectedColumnNames())
+		})
+
 		It("only treats headers as checked if the event specific logs have been checked", func() {
 			_, err = db.Exec(`INSERT INTO public.checked_headers (header_id) VALUES ($1)`, headerIDs[1])
 			Expect(err).NotTo(HaveOccurred())
@@ -111,11 +119,14 @@ var _ = Describe("Repository utilities", func() {
 	Describe("GetCheckedColumnNames", func() {
 		It("gets the column names from checked_headers", func() {
 			db := test_config.NewTestDB(test_config.NewTestNode())
+			hr := r2.NewHeaderRepository(db)
+			hr.AddCheckColumns(getExpectedColumnNames())
 			test_config.CleanTestDB(db)
 			expectedColumnNames := getExpectedColumnNames()
 			actualColumnNames, err := shared.GetCheckedColumnNames(db)
 			Expect(err).NotTo(HaveOccurred())
 			Expect(actualColumnNames).To(Equal(expectedColumnNames))
+			test_config.CleanCheckedHeadersTable(db, getExpectedColumnNames())
 		})
 	})