deep-stack/ipld-eth-server
4
0
Fork 0
forked from cerc-io/ipld-eth-server
Code Pull Requests Activity

VDB 207 refactor more repo tests (#107)

Browse Source 
* Use shared repo tests for vat flux

* Use shared repo methods for vat flux

* Use shared repo test examples for vat fold

* Use shared repository methods for vat fold

* Use shared repo test examples for vat grab

* Use shared repo methods for vat grab

* Use shared repo test examples for vat heal

* Use shared repo methods for vat heal
This commit is contained in:
Elizabeth
2018-11-09 14:54:22 -06:00
committed by GitHub
parent c1e10f09fb
commit 672269effa
9 changed files with 139 additions and 773 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/transformers/vat_heal/repository.go
+5 -21
View File
@@ -19,6 +19,8 @@ import (
"github.com/vulcanize/vulcanizedb/pkg/core"
"github.com/vulcanize/vulcanizedb/pkg/datastore/postgres"
"github.com/vulcanize/vulcanizedb/pkg/transformers/shared"
"github.com/vulcanize/vulcanizedb/pkg/transformers/shared/constants"
)
type VatHealRepository struct {
@@ -50,10 +52,7 @@ func (repository VatHealRepository) Create(headerId int64, models []interface{})
}
}
_, err = tx.Exec(`INSERT INTO public.checked_headers (header_id, vat_heal_checked)
VALUES($1, $2)
ON CONFLICT (header_id) DO
UPDATE SET vat_heal_checked = $2`, headerId, true)
err = shared.MarkHeaderCheckedInTransaction(headerId, tx, constants.VatHealChecked)
if err != nil {
tx.Rollback()
return err
@@ -62,24 +61,9 @@ func (repository VatHealRepository) Create(headerId int64, models []interface{})
}
func (repository VatHealRepository) MissingHeaders(startingBlock, endingBlock int64) ([]core.Header, error) {
var headers []core.Header
err := repository.db.Select(&headers,
`SELECT headers.id, block_number from headers
LEFT JOIN checked_headers on headers.id = header_id
WHERE (header_id ISNULL OR vat_heal_checked IS FALSE)
AND headers.block_number >= $1
AND headers.block_number <= $2
AND headers.eth_node_fingerprint = $3`,
startingBlock, endingBlock, repository.db.Node.ID)
return headers, err
return shared.MissingHeaders(startingBlock, endingBlock, repository.db, constants.VatHealChecked)
}
func (repository VatHealRepository) MarkHeaderChecked(headerId int64) error {
_, err := repository.db.Exec(`INSERT INTO public.checked_headers (header_id, vat_heal_checked)
VALUES($1, $2)
ON CONFLICT (header_id) DO
UPDATE SET vat_heal_checked = $2`, headerId, true)
return err
return shared.MarkHeaderChecked(headerId, repository.db, constants.VatHealChecked)
}
pkg/transformers/vat_heal/repository_test.go
+27 -175
View File
@@ -15,26 +15,23 @@
package vat_heal_test
import (
"math/rand"
. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"
"github.com/vulcanize/vulcanizedb/pkg/core"
"github.com/vulcanize/vulcanizedb/pkg/datastore/postgres"
"github.com/vulcanize/vulcanizedb/pkg/datastore/postgres/repositories"
"github.com/vulcanize/vulcanizedb/pkg/fakes"
"github.com/vulcanize/vulcanizedb/pkg/transformers/shared/constants"
"github.com/vulcanize/vulcanizedb/pkg/transformers/test_data"
"github.com/vulcanize/vulcanizedb/pkg/transformers/test_data/shared_behaviors"
"github.com/vulcanize/vulcanizedb/pkg/transformers/vat_heal"
"github.com/vulcanize/vulcanizedb/test_config"
)
var _ = Describe("VatHeal Repository", func() {
var (
db *postgres.DB
repository vat_heal.VatHealRepository
headerRepository repositories.HeaderRepository
err error
db *postgres.DB
repository vat_heal.VatHealRepository
)
BeforeEach(func() {
@@ -42,7 +39,6 @@ var _ = Describe("VatHeal Repository", func() {
test_config.CleanTestDB(db)
repository = vat_heal.VatHealRepository{}
repository.SetDB(db)
headerRepository = repositories.NewHeaderRepository(db)
})
type VatHealDBResult struct {
@@ -51,19 +47,23 @@ var _ = Describe("VatHeal Repository", func() {
HeaderId int64 `db:"header_id"`
}
type CheckedHeaderResult struct {
VatHealChecked bool `db:"vat_heal_checked"`
}
Describe("Create", func() {
var headerId int64
modelWithDifferentLogIdx := test_data.VatHealModel
modelWithDifferentLogIdx.LogIndex++
inputs := shared_behaviors.CreateBehaviorInputs{
CheckedHeaderColumnName: constants.VatHealChecked,
LogEventTableName: "maker.vat_heal",
TestModel: test_data.VatHealModel,
ModelWithDifferentLogIdx: modelWithDifferentLogIdx,
Repository: &repository,
}
BeforeEach(func() {
headerId, err = headerRepository.CreateOrUpdateHeader(fakes.FakeHeader)
Expect(err).NotTo(HaveOccurred())
})
shared_behaviors.SharedRepositoryCreateBehaviors(&inputs)
It("persists vat heal records", func() {
headerRepository := repositories.NewHeaderRepository(db)
headerId, err := headerRepository.CreateOrUpdateHeader(fakes.FakeHeader)
Expect(err).NotTo(HaveOccurred())
anotherVatHeal := test_data.VatHealModel
anotherVatHeal.LogIndex = test_data.VatHealModel.LogIndex + 1
err = repository.Create(headerId, []interface{}{test_data.VatHealModel, anotherVatHeal})
@@ -81,171 +81,23 @@ var _ = Describe("VatHeal Repository", func() {
Expect(dbResult[0].Raw).To(MatchJSON(test_data.VatHealModel.Raw))
Expect(dbResult[0].HeaderId).To(Equal(headerId))
})
It("returns an error if the insertion fails", func() {
err = repository.Create(headerId, []interface{}{test_data.VatHealModel})
Expect(err).NotTo(HaveOccurred())
err = repository.Create(headerId, []interface{}{test_data.VatHealModel})
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("pq: duplicate key value violates unique constraint"))
})
It("marks the header as checked for vat heal logs", func() {
err = repository.Create(headerId, []interface{}{test_data.VatHealModel})
Expect(err).NotTo(HaveOccurred())
var headerChecked bool
err = db.Get(&headerChecked, `SELECT vat_heal_checked FROM public.checked_headers WHERE header_id = $1`, headerId)
Expect(err).NotTo(HaveOccurred())
Expect(headerChecked).To(BeTrue())
})
It("updates the header to checked if checked headers row already exists", func() {
_, err = db.Exec(`INSERT INTO public.checked_headers (header_id) VALUES ($1)`, headerId)
Expect(err).NotTo(HaveOccurred())
err = repository.Create(headerId, []interface{}{test_data.VatHealModel})
Expect(err).NotTo(HaveOccurred())
var headerChecked bool
err = db.Get(&headerChecked, `SELECT vat_heal_checked FROM public.checked_headers WHERE header_id = $1`, headerId)
Expect(err).NotTo(HaveOccurred())
Expect(headerChecked).To(BeTrue())
})
It("removes vat heal if corresponding header is deleted", func() {
err = repository.Create(headerId, []interface{}{test_data.VatHealModel})
Expect(err).NotTo(HaveOccurred())
_, err = db.Exec(`DELETE FROM headers WHERE id = $1`, headerId)
Expect(err).NotTo(HaveOccurred())
var count int
err = db.QueryRow(`SELECT count(*) from maker.vat_heal`).Scan(&count)
Expect(err).NotTo(HaveOccurred())
Expect(count).To(Equal(0))
})
It("returns an error if the wrong model types are passed in", func() {
err = repository.Create(headerId, []interface{}{test_data.WrongModel{}})
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("model of type test_data.WrongModel, not vat_heal.VatHealModel"))
})
It("wraps create in a transaction", func() {
err = repository.Create(headerId, []interface{}{test_data.VatHealModel, test_data.VatHealModel})
Expect(err).To(HaveOccurred())
var count int
err = db.QueryRowx(`SELECT count(*) FROM maker.vat_heal`).Scan(&count)
Expect(count).To(Equal(0))
})
})
Describe("MissingHeaders", func() {
var (
startingBlock, vatHealBlock, endingBlock, outsideRangeBlock int64
blockNumbers, headerIds []int64
)
inputs := shared_behaviors.MissingHeadersBehaviorInputs{
Repository: &repository,
RepositoryTwo: &vat_heal.VatHealRepository{},
}
BeforeEach(func() {
startingBlock = rand.Int63()
vatHealBlock = startingBlock + 1
endingBlock = startingBlock + 2
outsideRangeBlock = startingBlock + 3
headerIds = []int64{}
blockNumbers = []int64{startingBlock, vatHealBlock, endingBlock, outsideRangeBlock}
for _, n := range blockNumbers {
headerId, err := headerRepository.CreateOrUpdateHeader(fakes.GetFakeHeader(n))
Expect(err).NotTo(HaveOccurred())
headerIds = append(headerIds, headerId)
}
})
It("returns headers that haven't been checked", func() {
err = repository.MarkHeaderChecked(headerIds[0])
Expect(err).NotTo(HaveOccurred())
headers, err := repository.MissingHeaders(startingBlock, endingBlock)
Expect(err).NotTo(HaveOccurred())
Expect(headers[0].Id).To(Or(Equal(headerIds[1]), Equal(headerIds[2])))
Expect(headers[1].Id).To(Or(Equal(headerIds[1]), Equal(headerIds[2])))
Expect(len(headers)).To(Equal(2))
})
It("returns header ids when checked_headers.vat_heal is false", func() {
err = repository.MarkHeaderChecked(headerIds[0])
_, err = db.Exec(`INSERT INTO checked_headers (header_id) VALUES ($1)`, headerIds[1])
Expect(err).NotTo(HaveOccurred())
headers, err := repository.MissingHeaders(startingBlock, endingBlock)
Expect(err).NotTo(HaveOccurred())
Expect(headers[0].Id).To(Or(Equal(headerIds[1]), Equal(headerIds[2])))
Expect(headers[1].Id).To(Or(Equal(headerIds[1]), Equal(headerIds[2])))
Expect(len(headers)).To(Equal(2))
})
It("only returns header ids for the current node", func() {
db2 := test_config.NewTestDB(core.Node{ID: "second node"})
headerRepository2 := repositories.NewHeaderRepository(db2)
repository2 := vat_heal.VatHealRepository{}
repository2.SetDB(db2)
for _, n := range blockNumbers {
_, err = headerRepository2.CreateOrUpdateHeader(fakes.GetFakeHeader(n))
Expect(err).NotTo(HaveOccurred())
}
err = repository.MarkHeaderChecked(headerIds[0])
Expect(err).NotTo(HaveOccurred())
nodeOneMissingHeaders, err := repository.MissingHeaders(startingBlock, endingBlock)
Expect(err).NotTo(HaveOccurred())
Expect(len(nodeOneMissingHeaders)).To(Equal(2))
nodeTwoMissingHeaders, err := repository2.MissingHeaders(startingBlock, endingBlock)
Expect(err).NotTo(HaveOccurred())
Expect(len(nodeTwoMissingHeaders)).To(Equal(3))
})
shared_behaviors.SharedRepositoryMissingHeadersBehaviors(&inputs)
})
Describe("MarkCheckedHeader", func() {
var headerId int64
inputs := shared_behaviors.MarkedHeaderCheckedBehaviorInputs{
CheckedHeaderColumnName: constants.VatHealChecked,
Repository: &repository,
}
BeforeEach(func() {
headerId, err = headerRepository.CreateOrUpdateHeader(fakes.FakeHeader)
Expect(err).NotTo(HaveOccurred())
})
It("creates a new checked_header record", func() {
err := repository.MarkHeaderChecked(headerId)
Expect(err).NotTo(HaveOccurred())
var checkedHeaderResult = CheckedHeaderResult{}
err = db.Get(&checkedHeaderResult, `SELECT vat_heal_checked FROM checked_headers WHERE header_id = $1`, headerId)
Expect(err).NotTo(HaveOccurred())
Expect(checkedHeaderResult.VatHealChecked).To(BeTrue())
})
It("updates an existing checked header", func() {
_, err := db.Exec(`INSERT INTO checked_headers (header_id) VALUES($1)`, headerId)
Expect(err).NotTo(HaveOccurred())
var checkedHeaderResult CheckedHeaderResult
err = db.Get(&checkedHeaderResult, `SELECT vat_heal_checked FROM checked_headers WHERE header_id = $1`, headerId)
Expect(err).NotTo(HaveOccurred())
Expect(checkedHeaderResult.VatHealChecked).To(BeFalse())
err = repository.MarkHeaderChecked(headerId)
Expect(err).NotTo(HaveOccurred())
err = db.Get(&checkedHeaderResult, `SELECT vat_heal_checked FROM checked_headers WHERE header_id = $1`, headerId)
Expect(err).NotTo(HaveOccurred())
Expect(checkedHeaderResult.VatHealChecked).To(BeTrue())
})
shared_behaviors.SharedRepositoryMarkHeaderCheckedBehaviors(&inputs)
})
})