begin work on: Add checked_headers column for methods that are polled so taht we don’t duplicate; Add batching of method polling so that we arent generating a rediculously large account address list before using it to poll methods (or persist the list in pg?); User passed ABI and other ways to get ABI; Add ability to collect []byte and hashes from events and use them in method polling same manner as addresses; Event filter addrs => only those event’s addresses/hashes are used for polling; Option to persist seen address/hash/bytes lists into pg; Only generate lists of addresses, []byte, or hashes if a method will use them later

pkg/omni/light/converter/converter.go

@@ -25,6 +25,7 @@ import (
 
 	"github.com/ethereum/go-ethereum/accounts/abi/bind"
 	"github.com/ethereum/go-ethereum/common"
+	"github.com/ethereum/go-ethereum/common/hexutil"
 	gethTypes "github.com/ethereum/go-ethereum/core/types"
 
 	"github.com/vulcanize/vulcanizedb/pkg/omni/shared/contract"
@@ -67,6 +68,9 @@ func (c *converter) Convert(logs []gethTypes.Log, event types.Event, headerID in
 		}
 
 		strValues := make(map[string]string, len(values))
+		seenBytes := make([]interface{}, 0, len(values))
+		seenAddrs := make([]interface{}, 0, len(values))
+		seenHashes := make([]interface{}, 0, len(values))
 		for fieldName, input := range values {
 			// Postgres cannot handle custom types, resolve everything to strings
 			switch input.(type) {
@@ -76,17 +80,19 @@ func (c *converter) Convert(logs []gethTypes.Log, event types.Event, headerID in
 			case common.Address:
 				a := input.(common.Address)
 				strValues[fieldName] = a.String()
-				c.ContractInfo.AddTokenHolderAddress(a.String()) // cache address in a list of contract's token holder addresses
+				seenAddrs = append(seenAddrs, a)
 			case common.Hash:
 				h := input.(common.Hash)
 				strValues[fieldName] = h.String()
+				seenHashes = append(seenHashes, h)
 			case string:
 				strValues[fieldName] = input.(string)
 			case bool:
 				strValues[fieldName] = strconv.FormatBool(input.(bool))
 			case []byte:
 				b := input.([]byte)
-				strValues[fieldName] = string(b)
+				strValues[fieldName] = hexutil.Encode(b)
+				seenBytes = append(seenBytes, b)
 			case byte:
 				b := input.(byte)
 				strValues[fieldName] = string(b)
@@ -109,6 +115,17 @@ func (c *converter) Convert(logs []gethTypes.Log, event types.Event, headerID in
 				TransactionIndex: log.TxIndex,
 				Id:               headerID,
 			})
+
+			// Cache emitted values if their caching is turned on
+			if c.ContractInfo.EmittedAddrs != nil {
+				c.ContractInfo.AddEmittedAddr(seenAddrs...)
+			}
+			if c.ContractInfo.EmittedHashes != nil {
+				c.ContractInfo.AddEmittedHash(seenHashes...)
+			}
+			if c.ContractInfo.EmittedBytes != nil {
+				c.ContractInfo.AddEmittedBytes(seenBytes...)
+			}
 		}
 	}
 

pkg/omni/light/converter/converter_test.go

@@ -84,21 +84,21 @@ var _ = Describe("Converter", func() {
 			_, err := c.Convert([]types.Log{mocks.MockTransferLog1, mocks.MockTransferLog2}, event, 232)
 			Expect(err).ToNot(HaveOccurred())
 
-			b, ok := con.TknHolderAddrs["0x000000000000000000000000000000000000Af21"]
+			b, ok := con.EmittedAddrs[common.HexToAddress("0x000000000000000000000000000000000000Af21")]
 			Expect(ok).To(Equal(true))
 			Expect(b).To(Equal(true))
 
-			b, ok = con.TknHolderAddrs["0x09BbBBE21a5975cAc061D82f7b843bCE061BA391"]
+			b, ok = con.EmittedAddrs[common.HexToAddress("0x09BbBBE21a5975cAc061D82f7b843bCE061BA391")]
 			Expect(ok).To(Equal(true))
 			Expect(b).To(Equal(true))
 
-			_, ok = con.TknHolderAddrs["0x"]
+			_, ok = con.EmittedAddrs[common.HexToAddress("0x")]
 			Expect(ok).To(Equal(false))
 
-			_, ok = con.TknHolderAddrs[""]
+			_, ok = con.EmittedAddrs[""]
 			Expect(ok).To(Equal(false))
 
-			_, ok = con.TknHolderAddrs["0x09THISE21a5IS5cFAKE1D82fAND43bCE06MADEUP"]
+			_, ok = con.EmittedAddrs[common.HexToAddress("0x09THISE21a5IS5cFAKE1D82fAND43bCE06MADEUP")]
 			Expect(ok).To(Equal(false))
 		})