begin work on: Add checked_headers column for methods that are polled so taht we don’t duplicate; Add batching of method polling so that we arent generating a rediculously large account address list before using it to poll methods (or persist the list in pg?); User passed ABI and other ways to get ABI; Add ability to collect []byte and hashes from events and use them in method polling same manner as addresses; Event filter addrs => only those event’s addresses/hashes are used for polling; Option to persist seen address/hash/bytes lists into pg; Only generate lists of addresses, []byte, or hashes if a method will use them later

pkg/omni/full/converter/converter.go

@@ -69,7 +69,9 @@ func (c *converter) Convert(watchedEvent core.WatchedEvent, event types.Event) (
 	}
 
 	strValues := make(map[string]string, len(values))
-
+	seenBytes := make([]interface{}, 0, len(values))
+	seenAddrs := make([]interface{}, 0, len(values))
+	seenHashes := make([]interface{}, 0, len(values))
 	for fieldName, input := range values {
 		// Postgres cannot handle custom types, resolve to strings
 		switch input.(type) {
@@ -79,10 +81,11 @@ func (c *converter) Convert(watchedEvent core.WatchedEvent, event types.Event) (
 		case common.Address:
 			a := input.(common.Address)
 			strValues[fieldName] = a.String()
-			c.ContractInfo.AddTokenHolderAddress(a.String()) // cache address in a list of contract's token holder addresses
+			seenAddrs = append(seenAddrs, a)
 		case common.Hash:
 			h := input.(common.Hash)
 			strValues[fieldName] = h.String()
+			seenHashes = append(seenHashes, h)
 		case string:
 			strValues[fieldName] = input.(string)
 		case bool:
@@ -90,6 +93,7 @@ func (c *converter) Convert(watchedEvent core.WatchedEvent, event types.Event) (
 		case []byte:
 			b := input.([]byte)
 			strValues[fieldName] = string(b)
+			seenBytes = append(seenBytes, b)
 		case byte:
 			b := input.(byte)
 			strValues[fieldName] = string(b)
@@ -107,6 +111,17 @@ func (c *converter) Convert(watchedEvent core.WatchedEvent, event types.Event) (
 			Tx:     watchedEvent.TxHash,
 		}
 
+		// Cache emitted values if their caching is turned on
+		if c.ContractInfo.EmittedAddrs != nil {
+			c.ContractInfo.AddEmittedAddr(seenAddrs...)
+		}
+		if c.ContractInfo.EmittedHashes != nil {
+			c.ContractInfo.AddEmittedHash(seenHashes...)
+		}
+		if c.ContractInfo.EmittedBytes != nil {
+			c.ContractInfo.AddEmittedBytes(seenBytes...)
+		}
+
 		return eventLog, nil
 	}
 

pkg/omni/full/converter/converter_test.go

@@ -81,21 +81,21 @@ var _ = Describe("Converter", func() {
 			_, err := c.Convert(mocks.MockTranferEvent, event)
 			Expect(err).ToNot(HaveOccurred())
 
-			b, ok := con.TknHolderAddrs["0x000000000000000000000000000000000000Af21"]
+			b, ok := con.EmittedAddrs[common.HexToAddress("0x000000000000000000000000000000000000Af21")]
 			Expect(ok).To(Equal(true))
 			Expect(b).To(Equal(true))
 
-			b, ok = con.TknHolderAddrs["0x09BbBBE21a5975cAc061D82f7b843bCE061BA391"]
+			b, ok = con.EmittedAddrs[common.HexToAddress("0x09BbBBE21a5975cAc061D82f7b843bCE061BA391")]
 			Expect(ok).To(Equal(true))
 			Expect(b).To(Equal(true))
 
-			_, ok = con.TknHolderAddrs["0x"]
+			_, ok = con.EmittedAddrs[common.HexToAddress("0x")]
 			Expect(ok).To(Equal(false))
 
-			_, ok = con.TknHolderAddrs[""]
+			_, ok = con.EmittedAddrs[""]
 			Expect(ok).To(Equal(false))
 
-			_, ok = con.TknHolderAddrs["0x09THISE21a5IS5cFAKE1D82fAND43bCE06MADEUP"]
+			_, ok = con.EmittedAddrs[common.HexToAddress("0x09THISE21a5IS5cFAKE1D82fAND43bCE06MADEUP")]
 			Expect(ok).To(Equal(false))
 		})