Use explicit image hash, not latest tag. #33

Merged
telackey merged 3 commits from telackey/hash into main 2022-11-01 22:53:33 +00:00
2 changed files with 2 additions and 2 deletions
Showing only changes of commit 734650b9ea - Show all commits

View File

@ -1,4 +1,4 @@
Review

Should it be like:
FROM skylenet/ethereum-genesis-generator@sha256:210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3 ?

Should it be like: `FROM skylenet/ethereum-genesis-generator@sha256:210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3` ?
Review

Should it be like:
FROM skylenet/ethereum-genesis-generator@sha256:210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3 ?

Should it be like: `FROM skylenet/ethereum-genesis-generator@sha256:210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3` ?
Review

Let me find out. I hope so, because it's easier to read. My first attempt was skylenet/ethereum-genesis-generator@210353ce7c, but that just got interpreted as a tag...

Let me find out. I hope so, because it's easier to read. My first attempt was skylenet/ethereum-genesis-generator@210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3, but that just got interpreted as a tag...
Review

Let me find out. I hope so, because it's easier to read. My first attempt was skylenet/ethereum-genesis-generator@210353ce7c, but that just got interpreted as a tag...

Let me find out. I hope so, because it's easier to read. My first attempt was skylenet/ethereum-genesis-generator@210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3, but that just got interpreted as a tag...
Review

Hurray! I also updated the reference to sigp/lcli to use an explicit version.

Hurray! I also updated the reference to `sigp/lcli` to use an explicit version.
Review

Hurray! I also updated the reference to sigp/lcli to use an explicit version.

Hurray! I also updated the reference to `sigp/lcli` to use an explicit version.
FROM skylenet/ethereum-genesis-generator AS ethgen
Review

Should it be like:
FROM skylenet/ethereum-genesis-generator@sha256:210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3 ?

Should it be like: `FROM skylenet/ethereum-genesis-generator@sha256:210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3` ?
Review

Let me find out. I hope so, because it's easier to read. My first attempt was skylenet/ethereum-genesis-generator@210353ce7c, but that just got interpreted as a tag...

Let me find out. I hope so, because it's easier to read. My first attempt was skylenet/ethereum-genesis-generator@210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3, but that just got interpreted as a tag...
Review

Hurray! I also updated the reference to sigp/lcli to use an explicit version.

Hurray! I also updated the reference to `sigp/lcli` to use an explicit version.
FROM 210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3 AS ethgen # skylenet/ethereum-genesis-generator
Review

Should it be like:
FROM skylenet/ethereum-genesis-generator@sha256:210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3 ?

Should it be like: `FROM skylenet/ethereum-genesis-generator@sha256:210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3` ?
Review

Let me find out. I hope so, because it's easier to read. My first attempt was skylenet/ethereum-genesis-generator@210353ce7c, but that just got interpreted as a tag...

Let me find out. I hope so, because it's easier to read. My first attempt was skylenet/ethereum-genesis-generator@210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3, but that just got interpreted as a tag...
Review

Hurray! I also updated the reference to sigp/lcli to use an explicit version.

Hurray! I also updated the reference to `sigp/lcli` to use an explicit version.
FROM cerc/go-ethereum:local
RUN apk add --no-cache python3 python3-dev py3-pip curl wget jq build-base gettext libintl openssl bash

Review

Should it be like:
FROM skylenet/ethereum-genesis-generator@sha256:210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3 ?

Should it be like: `FROM skylenet/ethereum-genesis-generator@sha256:210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3` ?
Review

Should it be like:
FROM skylenet/ethereum-genesis-generator@sha256:210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3 ?

Should it be like: `FROM skylenet/ethereum-genesis-generator@sha256:210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3` ?
Review

Let me find out. I hope so, because it's easier to read. My first attempt was skylenet/ethereum-genesis-generator@210353ce7c, but that just got interpreted as a tag...

Let me find out. I hope so, because it's easier to read. My first attempt was skylenet/ethereum-genesis-generator@210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3, but that just got interpreted as a tag...
Review

Let me find out. I hope so, because it's easier to read. My first attempt was skylenet/ethereum-genesis-generator@210353ce7c, but that just got interpreted as a tag...

Let me find out. I hope so, because it's easier to read. My first attempt was skylenet/ethereum-genesis-generator@210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3, but that just got interpreted as a tag...
Review

Hurray! I also updated the reference to sigp/lcli to use an explicit version.

Hurray! I also updated the reference to `sigp/lcli` to use an explicit version.
Review

Hurray! I also updated the reference to sigp/lcli to use an explicit version.

Hurray! I also updated the reference to `sigp/lcli` to use an explicit version.

View File

@ -1,5 +1,5 @@
FROM sigp/lcli AS lcli
FROM skylenet/ethereum-genesis-generator AS ethgen
FROM 210353ce7c898686bc5092f16c61220a76d357f51eff9c451e9ad1b9ad03d4d3 AS ethgen # skylenet/ethereum-genesis-generator
FROM cerc/fixturenet-eth-geth:local AS fnetgeth
FROM cerc/lighthouse:local