Support multiple NodePorts, static NodePort mapping, and add 'replicas' spec option #913

Merged

telackey merged 4 commits from telackey/nodeports into main 2024-08-09 02:32:07 +00:00

Conversation 0 Commits 4 Files Changed 5 +50 -23

telackey commented 2024-08-08 20:14:00 +00:00

Member

Copy Link

NodePort example:

network:
  ports:
    caddy:
     - 1234
     - 32020:2020

Replicas example:

replicas: 2

This also adds an optimization for k8s where if a directory matching the name of a configmap exists in beneath config/ in the stack, its contents will be copied into the corresponding configmap.

For example:

# Config files in the stack
❯ ls stack-orchestrator/config/caddyconfig
Caddyfile  Caddyfile.one-req-per-upstream-example

# ConfigMap in the spec
❯ cat foo.yml | grep config
...
configmaps:
  caddyconfig: ./configmaps/caddyconfig

# Create the deployment
❯ laconic-so --stack ~/cerc/caddy-ethcache/stack-orchestrator/stacks/caddy-ethcache deploy create --spec-file foo.yml

# The files from beneath config/<config_map_name> have been copied to the ConfigMap directory from the spec.
❯ ls deployment-001/configmaps/caddyconfig
Caddyfile  Caddyfile.one-req-per-upstream-example

NodePort example: ``` network: ports: caddy: - 1234 - 32020:2020 ``` Replicas example: ``` replicas: 2 ``` This also adds an optimization for k8s where if a directory matching the name of a configmap exists in beneath config/ in the stack, its contents will be copied into the corresponding configmap. For example: ``` # Config files in the stack ❯ ls stack-orchestrator/config/caddyconfig Caddyfile Caddyfile.one-req-per-upstream-example # ConfigMap in the spec ❯ cat foo.yml | grep config ... configmaps: caddyconfig: ./configmaps/caddyconfig # Create the deployment ❯ laconic-so --stack ~/cerc/caddy-ethcache/stack-orchestrator/stacks/caddy-ethcache deploy create --spec-file foo.yml # The files from beneath config/<config_map_name> have been copied to the ConfigMap directory from the spec. ❯ ls deployment-001/configmaps/caddyconfig Caddyfile Caddyfile.one-req-per-upstream-example ```

telackey added 1 commit 2024-08-08 20:14:01 +00:00

Multiple NodePorts and add replicas spec option 46943d41a8

telackey requested review from dboreham 2024-08-08 20:14:40 +00:00

telackey added 1 commit 2024-08-08 21:37:52 +00:00

If a directory exists under config/ which matches the name of a configmap, copy it during create. 21c61f9207

telackey added 1 commit 2024-08-08 21:41:21 +00:00

Debug line 5c65f9c432

telackey added 1 commit 2024-08-08 22:36:55 +00:00

lint 6b711a0cac

dboreham approved these changes 2024-08-08 22:56:08 +00:00

telackey merged commit 1def279d26 into main 2024-08-09 02:32:07 +00:00

telackey deleted branch telackey/nodeports 2024-08-09 02:32:08 +00:00

telackey referenced this issue from a commit 2024-08-09 02:32:08 +00:00

Support multiple NodePorts, static NodePort mapping, and add 'replicas' spec option (#913)

Sign in to join this conversation.

Reviewers

No reviewers

dboreham

Labels

Clear labels   

bug

Something isn't working

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

feature

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

in progress

  

invalid

This doesn't seem right

  

question

Further information is requested

  

wontfix

This will not be worked on

  

Copied from Github

An issue or PR manually copied from GitHub.

  

Kind/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No Label

bug

documentation

duplicate

enhancement

feature

good first issue

help wanted

in progress

invalid

question

wontfix

Copied from Github

Kind/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#913

No description provided.