cerc-io/stack-orchestrator
17
1
Fork 1
Code Issues 111 Pull Requests 13 Actions Packages Projects Releases 473 Wiki Activity

laconic-so build-npms seems to be broken #892

New Issue
Open
opened 2024-07-25 14:05:54 +00:00 by prathamesh · 5 comments
prathamesh commented 2024-07-25 14:05:54 +00:00
Member
Copy Link

While testing gitea-with-laconicd-fixturenet.md, on trying to run the build-npms step, it runs into the following error:

(venv) ➜  stack-orchestrator git:(v1.1.0-b26698b-202407250850) ✗ laconic-so --stack fixturenet-laconicd build-npms
Traceback (most recent call last):
  File "/home/prathamesh/deepstack/stack-orchestrator/venv/bin/laconic-so", line 33, in <module>
    sys.exit(load_entry_point('laconic-stack-orchestrator', 'console_scripts', 'laconic-so')())
  File "/home/prathamesh/deepstack/stack-orchestrator/venv/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/home/prathamesh/deepstack/stack-orchestrator/venv/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/home/prathamesh/deepstack/stack-orchestrator/venv/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/prathamesh/deepstack/stack-orchestrator/venv/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/prathamesh/deepstack/stack-orchestrator/venv/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/home/prathamesh/deepstack/stack-orchestrator/venv/lib/python3.10/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/prathamesh/deepstack/stack-orchestrator/stack_orchestrator/build/build_npms.py", line 57, in command
    registry_available = package_registry_stack.ensure_available()
  File "/home/prathamesh/deepstack/stack-orchestrator/stack_orchestrator/base.py", line 57, in ensure_available
    registry_running = get_stack_status(self.config, "package-registry")
  File "/home/prathamesh/deepstack/stack-orchestrator/stack_orchestrator/deploy/deploy.py", line 243, in get_stack_status
    deployer = Deployer(compose_files=cluster_context.compose_files, compose_project_name=cluster_context.cluster)
TypeError: Deployer() takes no arguments

Same result if I try running build-npms directly like:

laconic-so build-npms --include laconic-registry-cli
While testing [gitea-with-laconicd-fixturenet.md](https://git.vdb.to/cerc-io/stack-orchestrator/src/branch/main/docs/gitea-with-laconicd-fixturenet.md), on trying to run the `build-npms` step, it runs into the following error: ```bash (venv) ➜ stack-orchestrator git:(v1.1.0-b26698b-202407250850) ✗ laconic-so --stack fixturenet-laconicd build-npms Traceback (most recent call last): File "/home/prathamesh/deepstack/stack-orchestrator/venv/bin/laconic-so", line 33, in <module> sys.exit(load_entry_point('laconic-stack-orchestrator', 'console_scripts', 'laconic-so')()) File "/home/prathamesh/deepstack/stack-orchestrator/venv/lib/python3.10/site-packages/click/core.py", line 1157, in __call__ return self.main(*args, **kwargs) File "/home/prathamesh/deepstack/stack-orchestrator/venv/lib/python3.10/site-packages/click/core.py", line 1078, in main rv = self.invoke(ctx) File "/home/prathamesh/deepstack/stack-orchestrator/venv/lib/python3.10/site-packages/click/core.py", line 1688, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/home/prathamesh/deepstack/stack-orchestrator/venv/lib/python3.10/site-packages/click/core.py", line 1434, in invoke return ctx.invoke(self.callback, **ctx.params) File "/home/prathamesh/deepstack/stack-orchestrator/venv/lib/python3.10/site-packages/click/core.py", line 783, in invoke return __callback(*args, **kwargs) File "/home/prathamesh/deepstack/stack-orchestrator/venv/lib/python3.10/site-packages/click/decorators.py", line 33, in new_func return f(get_current_context(), *args, **kwargs) File "/home/prathamesh/deepstack/stack-orchestrator/stack_orchestrator/build/build_npms.py", line 57, in command registry_available = package_registry_stack.ensure_available() File "/home/prathamesh/deepstack/stack-orchestrator/stack_orchestrator/base.py", line 57, in ensure_available registry_running = get_stack_status(self.config, "package-registry") File "/home/prathamesh/deepstack/stack-orchestrator/stack_orchestrator/deploy/deploy.py", line 243, in get_stack_status deployer = Deployer(compose_files=cluster_context.compose_files, compose_project_name=cluster_context.cluster) TypeError: Deployer() takes no arguments ``` Same result if I try running `build-npms` directly like: ```bash laconic-so build-npms --include laconic-registry-cli ```
dboreham commented 2024-07-25 14:09:08 +00:00
Owner
Copy Link

Looks like another bug from a large set of changes merged a couple weeks ago. Investigating...

Looks like another bug from a large set of changes merged a couple weeks ago. Investigating...
dboreham self-assigned this 2024-07-25 14:09:11 +00:00
dboreham commented 2024-07-25 14:56:46 +00:00
Owner
Copy Link

Actually this bug is much older. It only shows when you're trying to publish the npm to a local gitea, which we haven't done for a long time. Publishing to a remote npm service should still work.

Actually this bug is much older. It only shows when you're trying to publish the npm to a local gitea, which we haven't done for a long time. Publishing to a remote npm service should still work.
dboreham commented 2024-07-25 15:29:21 +00:00
Owner
Copy Link

After some investigation I found that the package-registry stack upon which this code path depends, is also broken. See #893

After some investigation I found that the package-registry stack upon which this code path depends, is also broken. See https://git.vdb.to/cerc-io/stack-orchestrator/issues/893
dboreham commented 2024-07-25 15:30:15 +00:00
Owner
Copy Link

Since this bug relates to a code path that doesn't work anyway, what's the priority for fixing? Is this blocking publishing npms to git.vdb.to for example?

Since this bug relates to a code path that doesn't work anyway, what's the priority for fixing? Is this blocking publishing npms to git.vdb.to for example?
ashwin commented 2024-07-26 03:40:35 +00:00
Member
Copy Link

Since this bug relates to a code path that doesn't work anyway, what's the priority for fixing? Is this blocking publishing npms to git.vdb.to for example?

We aren't blocked on this, package releases are created from CI.

> Since this bug relates to a code path that doesn't work anyway, what's the priority for fixing? Is this blocking publishing npms to git.vdb.to for example? We aren't blocked on this, package releases are created from CI.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in progress

   
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dboreham
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#892
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?