cerc-io/stack-orchestrator
17
1
Fork 3
Code Issues 112 Pull Requests 19 Actions Packages Projects Releases 480 Wiki Activity

deploy-webapp command fails #876

New Issue
Closed
opened 2024-07-19 15:28:08 +00:00 by zramsay · 4 comments
zramsay commented 2024-07-19 15:28:08 +00:00
Member
Copy Link

e.g.,

laconic-so deploy-webapp create --kube-config ~/home/so/.kube/config-default.yaml --image-registry container-registry.pwa.realitynetwork.xyz --deployment-dir webapp-k8s-deployment --image cerc/test-progressive-web-app:local --url https://my-test-app.pwa.realitynetwork.xyz --env-file cerc/test-progressive-web-app/.env

fails with

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/Users/mito/bin/laconic-so/__main__.py", line 3, in <module>
  File "/Users/mito/bin/laconic-so/_bootstrap/__init__.py", line 253, in bootstrap
  File "/Users/mito/bin/laconic-so/_bootstrap/__init__.py", line 38, in run
  File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/stack_orchestrator/deploy/webapp/deploy_webapp.py", line 123, in create
    return create_deployment(ctx, deployment_dir, image, url, kube_config, image_registry, env_file)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/stack_orchestrator/deploy/webapp/deploy_webapp.py", line 74, in create_deployment
    deploy_command_context: DeployCommandContext = create_deploy_context(
                                                   ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/stack_orchestrator/deploy/deploy.py", line 87, in create_deploy_context
    cluster_context = _make_cluster_context(global_context, stack, include, exclude, cluster, env_file)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/stack_orchestrator/deploy/deploy.py", line 288, in _make_cluster_context
    deployment = stack_is_in_deployment(stack)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/stack_orchestrator/util.py", line 200, in stack_is_in_deployment
    return stack.joinpath(deployment_file_name).exists()
           ^^^^^^^^^^^^^^
AttributeError: 'str' object has no attribute 'joinpath'
e.g., ``` laconic-so deploy-webapp create --kube-config ~/home/so/.kube/config-default.yaml --image-registry container-registry.pwa.realitynetwork.xyz --deployment-dir webapp-k8s-deployment --image cerc/test-progressive-web-app:local --url https://my-test-app.pwa.realitynetwork.xyz --env-file cerc/test-progressive-web-app/.env ``` fails with ``` Traceback (most recent call last): File "<frozen runpy>", line 198, in _run_module_as_main File "<frozen runpy>", line 88, in _run_code File "/Users/mito/bin/laconic-so/__main__.py", line 3, in <module> File "/Users/mito/bin/laconic-so/_bootstrap/__init__.py", line 253, in bootstrap File "/Users/mito/bin/laconic-so/_bootstrap/__init__.py", line 38, in run File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/click/core.py", line 1157, in __call__ return self.main(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/click/core.py", line 1078, in main rv = self.invoke(ctx) ^^^^^^^^^^^^^^^^ File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/click/core.py", line 1688, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/click/core.py", line 1688, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/click/core.py", line 1434, in invoke return ctx.invoke(self.callback, **ctx.params) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/click/core.py", line 783, in invoke return __callback(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/click/decorators.py", line 33, in new_func return f(get_current_context(), *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/stack_orchestrator/deploy/webapp/deploy_webapp.py", line 123, in create return create_deployment(ctx, deployment_dir, image, url, kube_config, image_registry, env_file) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/stack_orchestrator/deploy/webapp/deploy_webapp.py", line 74, in create_deployment deploy_command_context: DeployCommandContext = create_deploy_context( ^^^^^^^^^^^^^^^^^^^^^^ File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/stack_orchestrator/deploy/deploy.py", line 87, in create_deploy_context cluster_context = _make_cluster_context(global_context, stack, include, exclude, cluster, env_file) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/stack_orchestrator/deploy/deploy.py", line 288, in _make_cluster_context deployment = stack_is_in_deployment(stack) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/mito/.shiv/laconic-so_7c29249d7da611fca2021cee35972aeedd8cbdad7b26a2796276a75ff1fc60ba/site-packages/stack_orchestrator/util.py", line 200, in stack_is_in_deployment return stack.joinpath(deployment_file_name).exists() ^^^^^^^^^^^^^^ AttributeError: 'str' object has no attribute 'joinpath' ```
dboreham commented 2024-07-19 15:41:02 +00:00
Owner
Copy Link

Need to determine why the test didn't catch this.

Need to determine why [the test](https://git.vdb.to/cerc-io/stack-orchestrator/src/branch/main/tests/webapp-test/run-webapp-test.sh) didn't catch this.
dboreham self-assigned this 2024-07-19 15:48:32 +00:00
dboreham commented 2024-07-19 17:05:54 +00:00
Owner
Copy Link

Proposed fix, added test: #877

Proposed fix, added test: https://git.vdb.to/cerc-io/stack-orchestrator/pulls/877
dboreham commented 2024-07-19 17:20:49 +00:00
Owner
Copy Link

Should be fixed now, please re-test.

Should be fixed now, please re-test.
zramsay commented 2024-07-19 18:32:25 +00:00
Author
Member
Copy Link

yes, thank you

yes, thank you
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in progress

   
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dboreham
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#876
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?