cerc-io/stack-orchestrator
17
1
Fork 1
Code Issues 110 Pull Requests 12 Actions Packages Projects Releases 473 Wiki Activity

deduplicate location of kubeconfig #871

New Issue
Open
opened 2024-07-12 15:55:39 +00:00 by zramsay · 2 comments
zramsay commented 2024-07-12 15:55:39 +00:00
Member
Copy Link

In a deployment, the kubeconfig.yml is specified in 2, sometimes 3 locations. For example, dir/spec.yml has the line kube-config: ~/.kube/config-default.yaml but also requires that same file at dir/kubeconfig.yml. In the case of the webapp-deployer, another copy of the file is required at dir/data/config/kube.yml.

In a deployment, the `kubeconfig.yml` is specified in 2, sometimes 3 locations. For example, `dir/spec.yml` has the line `kube-config: ~/.kube/config-default.yaml` but also requires that same file at `dir/kubeconfig.yml`. In the case of the webapp-deployer, another copy of the file is required at `dir/data/config/kube.yml`.
dboreham commented 2024-07-12 19:05:26 +00:00
Owner
Copy Link

I think this is ok for now. The spec file is the source for this config data. The file specified in the spec file is copied into the deployment dir on deployment creation to make deployment immutable (otherwise someone could modify or delete the file in its original location later). The spec file is copied into the deployment dir for similar reasons -- it isn't actually used. The webapp deployer is a special case where the app itself communicates with the cluster to do its job, so it has to break the fourth wall to get its credentials.

I think this is ok for now. The spec file is the source for this config data. The file specified in the spec file is copied into the deployment dir on deployment creation to make deployment immutable (otherwise someone could modify or delete the file in its original location later). The spec file is copied into the deployment dir for similar reasons -- it isn't actually used. The webapp deployer is a special case where the app itself communicates with the cluster to do its job, so it has to break the fourth wall to get its credentials.
srw commented 2024-07-16 21:47:12 +00:00
Owner
Copy Link

Just from an outside perspective my initial thought when deploying to k8s was to define a context to use in SO and have it automatically look for this context in my available ~/.kube/ config files, or take an activated context from something like kubie.

This falls in line more consistently with generic k8s tooling but obviously breaks the immersion of the deployment directory.

Just from an outside perspective my initial thought when deploying to k8s was to define a context to use in SO and have it automatically look for this context in my available ~/.kube/ config files, or take an activated context from something like kubie. This falls in line more consistently with generic k8s tooling but obviously breaks the immersion of the deployment directory.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in progress

   
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#871
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?