cerc-io/stack-orchestrator
17
1
Fork 3
Code Issues 113 Pull Requests 18 Actions 1 Packages Projects Releases 480 Wiki Activity

Derive the webapp host container id from stable data #865

Merged
dboreham merged 3 commits from dboreham/fix-webapp-container-id into main 2024-07-04 22:38:08 +00:00
Conversation 0 Commits 3 Files Changed 1 +9 -4
dboreham commented 2024-07-04 21:40:46 +00:00
Owner
Copy Link

Note that this change only affects the creation of new deployment directories. Any existing deployments are going to be unchanged, and hence the container id will be incorrect (we'll build a container with the new ID while the deployment data says to run the old one). This isn't as bad as it sounds because we have already broken stability of the ids (somehow). So we need to fix up any in-use deployments anyway.

Note that this change only affects the creation of new deployment directories. Any existing deployments are going to be unchanged, and hence the container id will be incorrect (we'll build a container with the new ID while the deployment data says to run the old one). This isn't as bad as it sounds because we have already broken stability of the ids (somehow). So we need to fix up any in-use deployments anyway.
dboreham added 1 commit 2024-07-04 21:40:47 +00:00
Derive the webapp host container id from stable data
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 37s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 4m44s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m43s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 5m31s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 8m34s
Details
8430c83e89
dboreham added 1 commit 2024-07-04 21:47:02 +00:00
Remove old comment
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 32s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 4m39s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 5m16s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m31s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 8m6s
Details
0938137df0
dboreham added 1 commit 2024-07-04 21:57:33 +00:00
Observe --force-rebuild
All checks were successful
Lint Checks / Run linter (pull_request) Successful in 37s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 4m24s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 4m21s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 5m13s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 7m39s
Details
3750f53b91
dboreham merged commit c3a1402042 into main 2024-07-04 22:38:08 +00:00
dboreham deleted branch dboreham/fix-webapp-container-id 2024-07-04 22:38:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in progress

   
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#865
No description provided.
Delete Branch "dboreham/fix-webapp-container-id"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?