Derive the webapp host container id from stable data #865

Merged

dboreham merged 3 commits from dboreham/fix-webapp-container-id into main 2024-07-04 22:38:08 +00:00

Conversation 0 Commits 3 Files Changed 1

+9 -4

dboreham commented 2024-07-04 21:40:46 +00:00

Contributor

Copy Link

Copy Source

Note that this change only affects the creation of new deployment directories. Any existing deployments are going to be unchanged, and hence the container id will be incorrect (we'll build a container with the new ID while the deployment data says to run the old one). This isn't as bad as it sounds because we have already broken stability of the ids (somehow). So we need to fix up any in-use deployments anyway.

Note that this change only affects the creation of new deployment directories. Any existing deployments are going to be unchanged, and hence the container id will be incorrect (we'll build a container with the new ID while the deployment data says to run the old one). This isn't as bad as it sounds because we have already broken stability of the ids (somehow). So we need to fix up any in-use deployments anyway.

dboreham added 1 commit 2024-07-04 21:40:47 +00:00

Derive the webapp host container id from stable data 8430c83e89

dboreham added 1 commit 2024-07-04 21:47:02 +00:00

Remove old comment 0938137df0

dboreham added 1 commit 2024-07-04 21:57:33 +00:00

Observe --force-rebuild 3750f53b91

dboreham merged commit c3a1402042 into main 2024-07-04 22:38:08 +00:00

dboreham referenced this issue from a commit 2024-07-04 22:38:09 +00:00

Derive the webapp host container id from stable data (#865)

dboreham deleted branch dboreham/fix-webapp-container-id 2024-07-04 22:38:13 +00:00

This repo is archived. You cannot comment on pull requests.

Reviewers

No Reviewers

Labels

Clear labels

K8s

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

feature

good first issue

Good for newcomers

help wanted

Extra attention is needed

in progress

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

Copied from Github

An issue or PR manually copied from GitHub.

Kind/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Reviewed

Confirmed

Issue has been confirmed

Reviewed

Duplicate

This issue or pull request already exists

Reviewed

Invalid

Invalid issue

Reviewed

Won't Fix

This issue won't be fixed

Status

Abandoned

Somebody has started to work on this but abandoned work

Status

Blocked

Something is blocking this issue or pull request

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

AFDudley Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay

No Assignees

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#865