public webapp deployments require "private:true" in package.json #858

New Issue

zramsay · 2024-06-25T18:27:34Z

zramsay commented

2024-06-25 18:27:34 +00:00

unclear why a not private repo requires this field

dboreham commented

2024-07-12 17:54:59 +00:00

This is "works for me" after testing with the test-pwa repo. I modified package.json to remove the private field:
caa2be6478

Then triggered deployment. The app was built and deployed ok.

This is "works for me" after testing with the test-pwa repo. I modified `package.json` to remove the private field: https://git.vdb.to/cerc-io/test-progressive-web-app/commit/caa2be6478906b443f336bb42e2f8b2117a7ea0c Then triggered deployment. The app was built and deployed ok.

dboreham commented

2024-07-12 17:56:24 +00:00

fwiw the only use for private: true is to prevent inadvertent publication of a package that wasn't intended to be published, so it should have no effect in the context of deployment since nothing is published.

Possibly some other framework (we're using next.js in the reproduction scenario) has a problem with it?

@zramsay do you have any more information to help with reproducing this one?

fwiw the only use for `private: true` is to prevent inadvertent publication of a package that wasn't intended to be published, so it should have no effect in the context of deployment since nothing is published. Possibly some other framework (we're using next.js in the reproduction scenario) has a problem with it? @zramsay do you have any more information to help with reproducing this one?

zramsay commented

2024-07-12 18:12:08 +00:00

i think we can close thank for the explanation

zramsay closed this issue

2024-07-12 18:12:09 +00:00

Sign in to join this conversation.

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#858