Don't error when CERC_GO_AUTH_TOKEN isn't set #574

roysc · 2023-10-11T22:14:09Z

roysc commented

2023-10-11 22:14:09 +00:00

All dependencies are now public.

telackey reviewed 2023-10-11 22:21:10 +00:00

telackey left a comment

Would it be better to do:

if [[ -n "${CERC_GO_AUTH_TOKEN}" ]]; then
    build_command_args="${build_command_args} --build-arg GIT_VDBTO_TOKEN=${CERC_GO_AUTH_TOKEN}"
fi

I'm just wondering of the results from passing --build-arg GIT_VDBTO_TOKEN=

Would it be better to do: ``` if [[ -n "${CERC_GO_AUTH_TOKEN}" ]]; then build_command_args="${build_command_args} --build-arg GIT_VDBTO_TOKEN=${CERC_GO_AUTH_TOKEN}" fi ``` I'm just wondering of the results from passing `--build-arg GIT_VDBTO_TOKEN=`

roysc commented

2023-10-11 22:51:11 +00:00

Yeah, that's a bit clearer. The end result is the same, since the bash if block gets skipped either way.

Yeah, that's a bit clearer. The end result is the same, since the bash `if` block gets skipped either way.

telackey approved these changes 2023-10-12 02:24:38 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#574