cerc-io/stack-orchestrator
17
1
Fork 1
Code Issues 111 Pull Requests 13 Actions Packages Projects Releases 473 Wiki Activity

Add port config to deployment spec. #498

Merged
telackey merged 9 commits from telackey/justports into main 2023-08-11 20:25:54 +00:00
Conversation 2 Commits 9 Files Changed 2 +72 -17
telackey commented 2023-08-11 19:01:55 +00:00
Member
Copy Link

After the change, ports as well as volumes will be customizable in the "spec" output from deploy init.

Example:

stack: mainnet-eth
ports:
  mainnet-eth-geth-1:
   - '8545'
   - '40000'
   - '6060'
  mainnet-eth-lighthouse-1:
   - '8001'
volumes:
  mainnet_eth_config_data: ./data/mainnet_eth_config_data
  mainnet_eth_geth_1_data: ./data/mainnet_eth_geth_1_data
  mainnet_eth_lighthouse_1_data: ./data/mainnet_eth_lighthouse_1_data
After the change, ports as well as volumes will be customizable in the "spec" output from `deploy init`. Example: ``` stack: mainnet-eth ports: mainnet-eth-geth-1: - '8545' - '40000' - '6060' mainnet-eth-lighthouse-1: - '8001' volumes: mainnet_eth_config_data: ./data/mainnet_eth_config_data mainnet_eth_geth_1_data: ./data/mainnet_eth_geth_1_data mainnet_eth_lighthouse_1_data: ./data/mainnet_eth_lighthouse_1_data ```
dboreham commented 2023-08-11 19:34:58 +00:00
Owner
Copy Link

After the change, ports as well as volumes will be customizable in the "spec" output from deploy init.

Example:

Can you update the example?

> After the change, ports as well as volumes will be customizable in the "spec" output from `deploy init`. > > Example: Can you update the example?
dboreham commented 2023-08-11 19:43:27 +00:00
Owner
Copy Link

Can you add host address/port mapping to one or more of the ports in the example so we can use it for doc?

Can you add host address/port mapping to one or more of the ports in the example so we can use it for doc?
dboreham reviewed 2023-08-11 19:58:24 +00:00
app/deployment_create.py
dboreham commented 2023-08-11 19:58:24 +00:00
Owner
Copy Link

Something looks wrong about this line.

Something looks wrong about this line.
telackey reviewed 2023-08-11 20:14:45 +00:00
app/deployment_create.py
telackey commented 2023-08-11 20:14:45 +00:00
Author
Member
Copy Link

Hah! That's what I get for making a last minute tweak.

Hah! That's what I get for making a last minute tweak.
dboreham approved these changes 2023-08-11 20:20:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dboreham
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in progress

   
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#498
No description provided.
Delete Branch "telackey/justports"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?