cerc-io/stack-orchestrator
17
1
Fork 2
Code Issues 112 Pull Requests 15 Actions Packages Projects Releases 473 Wiki Activity

geth container binary inconsistent with command options #454

New Issue
Closed
opened 2023-07-19 02:55:40 +00:00 by dboreham · 7 comments
dboreham commented 2023-07-19 02:55:40 +00:00
Owner
Copy Link

Testing mobymask-v2 stack I see this in the fixturenet-eth-geth container:

Incorrect Usage. flag provided but not defined: -log.vmodule

NAME:
   geth - the go-ethereum command line interface

USAGE:
   geth [global options] command [command options] [arguments...]

VERSION:
   1.11.5-statediff-4.3.9-alpha-4e7a42eb-20230406
Testing mobymask-v2 stack I see this in the fixturenet-eth-geth container: ``` Incorrect Usage. flag provided but not defined: -log.vmodule NAME: geth - the go-ethereum command line interface USAGE: geth [global options] command [command options] [arguments...] VERSION: 1.11.5-statediff-4.3.9-alpha-4e7a42eb-20230406 ```
dboreham commented 2023-07-19 03:08:55 +00:00
Author
Owner
Copy Link

This may have crept in with some plugeth changes, unnoticed because we don't run the fixturenet-eth test on every PR.

It looks like this commit : 809889f9f0 (diff-e397b8ae6dcabdce76c66636365b2f565020818ba4d2d55591d8259feefb16e3R133) introduced a command line option that seems to be invalid for regular geth (but probably ok for plugeth).

The result is that the geth fixturenet doesn't work.

This may have crept in with some plugeth changes, unnoticed because we don't run the fixturenet-eth test on every PR. It looks like this commit : https://github.com/cerc-io/stack-orchestrator/commit/809889f9f03c843a56b7cf1eb76767dbf0e913f8#diff-e397b8ae6dcabdce76c66636365b2f565020818ba4d2d55591d8259feefb16e3R133 introduced a command line option that seems to be invalid for regular geth (but probably ok for plugeth). The result is that the geth fixturenet doesn't work.
telackey commented 2023-07-19 03:10:28 +00:00
Member
Copy Link

This is odd, I'm using geth fixturenet.

This is odd, I'm using geth fixturenet.
telackey commented 2023-07-19 03:12:03 +00:00
Member
Copy Link
~/cerc/go-ethereum  v1.11.6-statediff-v5 ✗= ❯ make geth
env GO111MODULE=on go run build/ci.go install ./cmd/geth
>>> /home/telackey/opt/go1.20.5/bin/go build -ldflags "-X github.com/ethereum/go-ethereum/internal/version.gitCommit=1b72d2f737a031fd6617aa0954a6a5b96a487426 -X github.com/ethereum/go-ethereum/internal/version.gitDate=20230718 -extldflags '-Wl,-z,stack-size=0x800000'" -tags urfave_cli_no_docs -trimpath -v -o /home/telackey/cerc/go-ethereum/build/bin/geth ./cmd/geth
Done building.
Run "./build/bin/geth" to launch geth.
~/cerc/go-ethereum  v1.11.6-statediff-v5 ✗= ❯ build/bin/geth --help | grep -i vmodule
    --log.vmodule value
``` ~/cerc/go-ethereum  v1.11.6-statediff-v5 ✗= ❯ make geth env GO111MODULE=on go run build/ci.go install ./cmd/geth >>> /home/telackey/opt/go1.20.5/bin/go build -ldflags "-X github.com/ethereum/go-ethereum/internal/version.gitCommit=1b72d2f737a031fd6617aa0954a6a5b96a487426 -X github.com/ethereum/go-ethereum/internal/version.gitDate=20230718 -extldflags '-Wl,-z,stack-size=0x800000'" -tags urfave_cli_no_docs -trimpath -v -o /home/telackey/cerc/go-ethereum/build/bin/geth ./cmd/geth Done building. Run "./build/bin/geth" to launch geth. ~/cerc/go-ethereum  v1.11.6-statediff-v5 ✗= ❯ build/bin/geth --help | grep -i vmodule --log.vmodule value ```
telackey commented 2023-07-19 03:13:07 +00:00
Member
Copy Link

I actually finally switched it, because for awhile geth had been warning that --vmodule was deprecated and we needed to switch to --log.vmodule.

I actually finally switched it, because for awhile geth had been _warning_ that `--vmodule` was deprecated and we needed to switch to `--log.vmodule`.
dboreham commented 2023-07-19 03:13:55 +00:00
Author
Owner
Copy Link

This seems significant:

v1.11.6
This seems significant: ``` v1.11.6 ```
dboreham commented 2023-07-19 03:18:45 +00:00
Author
Owner
Copy Link

It looks like the problem is that our go-ethereum repo changes default branch.
That is problematic if you have an existing cloned tree because there's no way to know from the client side that the default branch changed. My setup therefore continued building old code, even though I'd told it to pull from git and force a container rebuild.

It looks like the problem is that our go-ethereum repo changes default branch. That is problematic if you have an existing cloned tree because there's no way to know from the client side that the default branch changed. My setup therefore continued building old code, even though I'd told it to pull from git and force a container rebuild.
dboreham commented 2023-07-19 04:08:49 +00:00
Author
Owner
Copy Link

Closing as machine-specific.

Closing as machine-specific.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in progress

   
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#454
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?