cerc-io/stack-orchestrator
Archived
12
1
Fork 3
Code Issues 117 Pull Requests 25 Actions Packages Projects Releases 493 Wiki Activity

Identify the purpose of docker volume fixturenet_geth_accounts #334

New Issue
Open
opened 2023-04-17 02:06:43 +00:00 by dboreham · 0 comments
dboreham commented 2023-04-17 02:06:43 +00:00
Contributor
Copy Link
Copy Source

This crept in with a recent PR. I'm not sure why we need it when we already had this endpoint for accounts discovery, e.g. used here.

Volume is used in these places:

https://github.com/cerc-io/stack-orchestrator/blob/main/app/data/compose/docker-compose-fixturenet-eth.yml#L28
https://github.com/cerc-io/stack-orchestrator/blob/main/app/data/compose/docker-compose-fixturenet-optimism.yml#L30

This crept in with a recent PR. I'm not sure why we need it when we already had [this endpoint](https://github.com/cerc-io/stack-orchestrator/blob/main/app/data/container-build/cerc-fixturenet-eth-geth/run-el.sh#L13) for accounts discovery, e.g. used [here](https://github.com/cerc-io/stack-orchestrator/blob/main/app/data/compose/docker-compose-tx-spammer.yml#L10). Volume is used in these places: https://github.com/cerc-io/stack-orchestrator/blob/main/app/data/compose/docker-compose-fixturenet-eth.yml#L28 https://github.com/cerc-io/stack-orchestrator/blob/main/app/data/compose/docker-compose-fixturenet-optimism.yml#L30
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
K8s
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 in progress
invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#334