cerc-io/stack-orchestrator
Archived
12
1
Fork 3
Code Issues 117 Pull Requests 25 Actions Packages Projects Releases 493 Wiki Activity

Add build and compose defintions for Merge 'fixturenet'. #24

Merged
telackey merged 6 commits from telackey/fixturenet into main 2022-10-14 20:11:56 +00:00
Conversation 10 Commits 6 Files Changed 22
+569
telackey commented 2022-10-14 17:56:38 +00:00
Contributor
Copy Link
Copy Source

Add container and compose info for setting up a post-Merge eth network for testing.

Add container and compose info for setting up a post-Merge eth network for testing.
compose/docker-compose-fixturenet-eth.yml
@@ -0,0 +76,4 @@
networks:
fixturenet-eth-net:
networks:
dboreham commented 2022-10-14 18:03:05 +00:00
Contributor

Add a comment about why we need this network defined.

Add a comment about why we need this network defined.
container-build/cerc-fixturenet-eth-geth/Dockerfile
dboreham commented 2022-10-14 18:53:58 +00:00
Contributor

Debug code left in?

Debug code left in?
container-build/cerc-fixturenet-eth-geth/genesis/accounts/accounts.csv
@@ -0,0 +1,6 @@
m/44'/60'/0'/0/0,0xe6CE22afe802CAf5fF7d3845cec8c736ecc8d61F,0x02cfc16a6212d7bb9dff89b603afbd856157c367de3ef6b626f205d9b150630ea0,0x888814df89c4358d7ddb3fa4b0213e7331239a80e1f013eaa7b2deca2a41a218
dboreham commented 2022-10-14 18:59:21 +00:00
Contributor

Should this be in ./config?

Should this be in ./config?
container-build/cerc-fixturenet-eth-geth/genesis/el/el-config.yaml
dboreham commented 2022-10-14 18:59:06 +00:00
Contributor

Should this be in ./config?

Should this be in ./config?
container-build/cerc-fixturenet-eth-geth/genesis/accounts/accounts.csv
@@ -0,0 +1,6 @@
m/44'/60'/0'/0/0,0xe6CE22afe802CAf5fF7d3845cec8c736ecc8d61F,0x02cfc16a6212d7bb9dff89b603afbd856157c367de3ef6b626f205d9b150630ea0,0x888814df89c4358d7ddb3fa4b0213e7331239a80e1f013eaa7b2deca2a41a218
telackey commented 2022-10-14 19:40:16 +00:00
Author
Contributor

I think it belongs here, because the accounts are used by ethereum-genesis-generator when it generates the genesis file with pre-funded accounts during the container build.

I think it belongs here, because the accounts are used by `ethereum-genesis-generator` when it generates the genesis file with pre-funded accounts during the container build.
container-build/cerc-fixturenet-eth-geth/genesis/el/el-config.yaml
@@ -0,0 +1,21 @@
mnemonic: "viable ketchup woman library opinion copy rhythm attend rose knock penalty practice photo bundle budget dentist enter round bind holiday useful arch danger lobster"
telackey commented 2022-10-14 19:41:27 +00:00
Author
Contributor

Same as with the accounts, I think it needs to stay here, as it is part of the input used to generate the genesis file during the container build.

Same as with the accounts, I think it needs to stay here, as it is part of the input used to generate the genesis file during the container build.
compose/docker-compose-fixturenet-eth.yml
@@ -0,0 +76,4 @@
networks:
fixturenet-eth-net:
networks:
telackey commented 2022-10-14 19:42:05 +00:00
Author
Contributor

Done

Done
container-build/cerc-fixturenet-eth-geth/genesis/accounts/accounts.csv
@@ -0,0 +1,6 @@
m/44'/60'/0'/0/0,0xe6CE22afe802CAf5fF7d3845cec8c736ecc8d61F,0x02cfc16a6212d7bb9dff89b603afbd856157c367de3ef6b626f205d9b150630ea0,0x888814df89c4358d7ddb3fa4b0213e7331239a80e1f013eaa7b2deca2a41a218
dboreham commented 2022-10-14 19:45:16 +00:00
Contributor

Can you point me to where that is run?

Can you point me to where that is run?
container-build/cerc-fixturenet-eth-geth/genesis/accounts/accounts.csv
@@ -0,0 +1,6 @@
m/44'/60'/0'/0/0,0xe6CE22afe802CAf5fF7d3845cec8c736ecc8d61F,0x02cfc16a6212d7bb9dff89b603afbd856157c367de3ef6b626f205d9b150630ea0,0x888814df89c4358d7ddb3fa4b0213e7331239a80e1f013eaa7b2deca2a41a218
telackey commented 2022-10-14 19:51:19 +00:00
Author
Contributor

https://github.com/cerc-io/stack-orchestrator/pull/24/files#diff-b2251121f1cc991ed1e0fd066bf19bec47a989e5ac03ad2a189583b72bf8eec8R10

I got my comments backwards on el-config.yaml and accounts.csv. The latter is a bit more complicated. Strictly speaking it out to be an output of the build step rather than an input, as the keys are predictably generated from the mnemonic in el-config.yaml.

There is an issue here: https://github.com/bozemanpass/merge-testnet/issues/1

https://github.com/cerc-io/stack-orchestrator/pull/24/files#diff-b2251121f1cc991ed1e0fd066bf19bec47a989e5ac03ad2a189583b72bf8eec8R10 I got my comments backwards on el-config.yaml and accounts.csv. The latter is a bit more complicated. Strictly speaking it out to be an *output* of the build step rather than an input, as the keys are predictably generated from the mnemonic in el-config.yaml. There is an issue here: https://github.com/bozemanpass/merge-testnet/issues/1
container-build/cerc-fixturenet-eth-geth/genesis/accounts/accounts.csv
@@ -0,0 +1,6 @@
m/44'/60'/0'/0/0,0xe6CE22afe802CAf5fF7d3845cec8c736ecc8d61F,0x02cfc16a6212d7bb9dff89b603afbd856157c367de3ef6b626f205d9b150630ea0,0x888814df89c4358d7ddb3fa4b0213e7331239a80e1f013eaa7b2deca2a41a218
dboreham commented 2022-10-14 19:54:07 +00:00
Contributor

Here: https://github.com/cerc-io/stack-orchestrator/pull/24/files#diff-87b2242d72cd90189e0e62f38fd4f98deca481208ab2ec476eba14de87e00fe5R25

Here: https://github.com/cerc-io/stack-orchestrator/pull/24/files#diff-87b2242d72cd90189e0e62f38fd4f98deca481208ab2ec476eba14de87e00fe5R25
container-build/cerc-fixturenet-eth-geth/genesis/el/el-config.yaml
@@ -0,0 +1,21 @@
mnemonic: "viable ketchup woman library opinion copy rhythm attend rose knock penalty practice photo bundle budget dentist enter round bind holiday useful arch danger lobster"
dboreham commented 2022-10-14 19:57:59 +00:00
Contributor

I think I got confused between build_el.sh and run_el.sh

I think I got confused between build_el.sh and run_el.sh
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
telackey
dboreham
Labels
Clear labels
K8s
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 in progress
invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#24