cerc-io/stack-orchestrator
Archived
12
1
Fork 3
Code Issues 117 Pull Requests 25 Actions Packages Projects Releases 493 Wiki Activity

Support CI test scenarios covered by old stack orchestrator #218

New Issue
Open
opened 2023-03-14 19:16:13 +00:00 by dboreham · 2 comments
dboreham commented 2023-03-14 19:16:13 +00:00
Contributor
Copy Link
Copy Source

e.g. in cerc/go-ethereum

e.g. in cerc/go-ethereum
dboreham commented 2023-04-10 16:03:05 +00:00
Author
Contributor
Copy Link
Copy Source

@telackey what's the story here? Did it just work?

@telackey what's the story here? Did it just work?
telackey commented 2023-04-10 19:02:58 +00:00
Contributor
Copy Link
Copy Source

It's a multipart answer. The first is that using go-ethereum as an example, I have become convinced that the old stack-orchestrator is not providing any scenario not already covered better by the new stack-orchestrator. In both old_tests.yml and tests.yml, the basic form is to create a testnet, add a TX, see that it is accepted, and then see that some content is in the statediff DB (the exact content is not verified). I do not see an advantage to keeping dual forms of that, and I think it is time to declare the old stack-orchestrator obsolete and simply use the new.

That said, I haven't tested stack-orchestrator specifically inside Gitea yet. It should work fine, in the same way that the statediff tests (which use docker compose directly) work, but I did not test it properly.

The hiccup (and this can be worked around) is getting the repos just so. Probably the best course is to:

  1. Also migrate ipld-eth-db into a test repo, so that the checkout step can work properly.
  2. Just symlink the repos instead of using the 'setup-repositories' in stack-orchestrator, because (at this time) that will attempt to checkout from GitHub.
  3. Build containers and run.

Alternately, we could provide SO with GitHub credentials and allow it to checkout the repos it needs from GitHub, but it seems like that might be more confusing, since code would be drawn from multiple sources.

It's a multipart answer. The first is that using go-ethereum as an example, I have become convinced that the old stack-orchestrator is not providing any scenario not already covered better by the new stack-orchestrator. In both old_tests.yml and tests.yml, the basic form is to create a testnet, add a TX, see that it is accepted, and then see that some content is in the statediff DB (the exact content is not verified). I do not see an advantage to keeping dual forms of that, and I think it is time to declare the old stack-orchestrator obsolete and simply use the new. That said, I haven't tested stack-orchestrator specifically inside Gitea yet. It _should_ work fine, in the same way that the statediff tests (which use `docker compose` directly) work, but I did not test it properly. The hiccup (and this can be worked around) is getting the repos just so. Probably the best course is to: 1) Also migrate ipld-eth-db into a test repo, so that the checkout step can work properly. 2) Just symlink the repos instead of using the 'setup-repositories' in stack-orchestrator, because (at this time) that will attempt to checkout from GitHub. 3) Build containers and run. Alternately, we could provide SO with GitHub credentials and allow it to checkout the repos it needs from GitHub, but it seems like that might be more confusing, since code would be drawn from multiple sources.
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
K8s
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 in progress
invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/stack-orchestrator#218