Compare commits

...

2 Commits

Author SHA1 Message Date
zramsay
25dce3f051 records wants string
Some checks failed
Lint Checks / Run linter (pull_request) Failing after 16s
K8s Deployment Control Test / Run deployment control suite on kind/k8s (pull_request) Failing after 1m23s
Smoke Test / Run basic test suite (pull_request) Failing after 1m6s
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Failing after 1m24s
Webapp Test / Run webapp test suite (pull_request) Successful in 1m50s
Deploy Test / Run deploy test suite (pull_request) Successful in 2m36s
2025-05-02 14:12:31 -04:00
zramsay
87251ba65b modifications to accept atom payments
Some checks failed
Lint Checks / Run linter (pull_request) Failing after 27s
Webapp Test / Run webapp test suite (pull_request) Successful in 1m52s
Deploy Test / Run deploy test suite (pull_request) Successful in 2m38s
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Successful in 4m5s
Smoke Test / Run basic test suite (pull_request) Successful in 1m32s
K8s Deployment Control Test / Run deployment control suite on kind/k8s (pull_request) Successful in 2m33s
2025-04-30 11:06:01 -04:00
3 changed files with 137 additions and 58 deletions

View File

@ -342,6 +342,17 @@ def dump_known_requests(filename, requests, status="SEEN"):
help="Requests must have a minimum payment to be processed (in alnt)", help="Requests must have a minimum payment to be processed (in alnt)",
default=0, default=0,
) )
@click.option(
"--atom-payment-address",
help="Cosmos ATOM address to receive payments",
default=None,
)
@click.option(
"--min-atom-payment",
help="Minimum required ATOM payment amount",
default=1,
type=float,
)
@click.option("--lrn", help="The LRN of this deployer.", required=True) @click.option("--lrn", help="The LRN of this deployer.", required=True)
@click.option( @click.option(
"--all-requests", "--all-requests",
@ -394,6 +405,8 @@ def command( # noqa: C901
recreate_on_deploy, recreate_on_deploy,
log_dir, log_dir,
min_required_payment, min_required_payment,
atom_payment_address,
min_atom_payment,
lrn, lrn,
config_upload_dir, config_upload_dir,
private_key_file, private_key_file,
@ -630,6 +643,8 @@ def command( # noqa: C901
payment_address, payment_address,
min_required_payment, min_required_payment,
main_logger, main_logger,
atom_payment_address,
min_atom_payment,
): ):
main_logger.log(f"{r.id}: Payment confirmed.") main_logger.log(f"{r.id}: Payment confirmed.")
requests_to_execute.append(r) requests_to_execute.append(r)

View File

@ -46,6 +46,17 @@ from stack_orchestrator.deploy.webapp.util import LaconicRegistryClient
help="List the minimum required payment (in alnt) to process a deployment request.", help="List the minimum required payment (in alnt) to process a deployment request.",
default=0, default=0,
) )
@click.option(
"--atom-payment-address",
help="The Cosmos ATOM address to which payments should be made.",
default=None,
)
@click.option(
"--min-atom-payment",
help="List the minimum required payment (in uatom) to process a deployment request.",
default="1000000uatom",
type=str,
)
@click.option( @click.option(
"--dry-run", "--dry-run",
help="Don't publish anything, just report what would be done.", help="Don't publish anything, just report what would be done.",
@ -60,6 +71,8 @@ def command( # noqa: C901
lrn, lrn,
payment_address, payment_address,
min_required_payment, min_required_payment,
atom_payment_address,
min_atom_payment,
dry_run, dry_run,
): ):
laconic = LaconicRegistryClient(laconic_config) laconic = LaconicRegistryClient(laconic_config)
@ -83,6 +96,10 @@ def command( # noqa: C901
webapp_deployer_record["record"][ webapp_deployer_record["record"][
"minimumPayment" "minimumPayment"
] = f"{min_required_payment}alnt" ] = f"{min_required_payment}alnt"
if atom_payment_address:
webapp_deployer_record["record"]["atomPaymentAddress"] = atom_payment_address
webapp_deployer_record["record"]["minimumAtomPayment"] = min_atom_payment
if dry_run: if dry_run:
yaml.dump(webapp_deployer_record, sys.stdout) yaml.dump(webapp_deployer_record, sys.stdout)

View File

@ -801,7 +801,7 @@ def skip_by_tag(r, include_tags, exclude_tags):
return False return False
def confirm_payment(laconic: LaconicRegistryClient, record, payment_address, min_amount, logger): def confirm_payment(laconic: LaconicRegistryClient, record, payment_address, min_amount, logger, atom_payment_address=None, atom_min_amount=None):
req_owner = laconic.get_owner(record) req_owner = laconic.get_owner(record)
if req_owner == payment_address: if req_owner == payment_address:
# No need to confirm payment if the sender and recipient are the same account. # No need to confirm payment if the sender and recipient are the same account.
@ -811,67 +811,114 @@ def confirm_payment(laconic: LaconicRegistryClient, record, payment_address, min
logger.log(f"{record.id}: no payment tx info") logger.log(f"{record.id}: no payment tx info")
return False return False
# Try to verify as a laconic payment first
tx = laconic.get_tx(record.attributes.payment) tx = laconic.get_tx(record.attributes.payment)
if not tx: if tx:
logger.log(f"{record.id}: cannot locate payment tx") if tx.code != 0:
return False logger.log(
f"{record.id}: payment tx {tx.hash} was not successful - code: {tx.code}, log: {tx.log}"
if tx.code != 0: )
logger.log(
f"{record.id}: payment tx {tx.hash} was not successful - code: {tx.code}, log: {tx.log}"
)
return False
if tx.sender != req_owner:
logger.log(
f"{record.id}: payment sender {tx.sender} in tx {tx.hash} does not match deployment "
f"request owner {req_owner}"
)
return False
if tx.recipient != payment_address:
logger.log(
f"{record.id}: payment recipient {tx.recipient} in tx {tx.hash} does not match {payment_address}"
)
return False
pay_denom = "".join([i for i in tx.amount if not i.isdigit()])
if pay_denom != "alnt":
logger.log(
f"{record.id}: {pay_denom} in tx {tx.hash} is not an expected payment denomination"
)
return False
pay_amount = int("".join([i for i in tx.amount if i.isdigit()]))
if pay_amount < min_amount:
logger.log(
f"{record.id}: payment amount {tx.amount} is less than minimum {min_amount}"
)
return False
# Check if the payment was already used on a deployment
used = laconic.app_deployments(
{"deployer": record.attributes.deployer, "payment": tx.hash}, all=True
)
if len(used):
# Fetch the app name from request record
used_request = laconic.get_record(used[0].attributes.request, require=True)
# Check that payment was used for deployment of same application
if record.attributes.application != used_request.attributes.application:
logger.log(f"{record.id}: payment {tx.hash} already used on a different application deployment {used}")
return False return False
used = laconic.app_deployment_removals( if tx.sender != req_owner:
{"deployer": record.attributes.deployer, "payment": tx.hash}, all=True logger.log(
) f"{record.id}: payment sender {tx.sender} in tx {tx.hash} does not match deployment "
if len(used): f"request owner {req_owner}"
logger.log( )
f"{record.id}: payment {tx.hash} already used on deployment removal {used}" return False
)
return False
return True if tx.recipient != payment_address:
logger.log(
f"{record.id}: payment recipient {tx.recipient} in tx {tx.hash} does not match {payment_address}"
)
return False
pay_denom = "".join([i for i in tx.amount if not i.isdigit()])
if pay_denom != "alnt":
logger.log(
f"{record.id}: {pay_denom} in tx {tx.hash} is not an expected payment denomination"
)
return False
pay_amount = int("".join([i for i in tx.amount if i.isdigit()]))
if pay_amount < min_amount:
logger.log(
f"{record.id}: payment amount {tx.amount} is less than minimum {min_amount}"
)
return False
# Check if the payment was already used on a deployment
used = laconic.app_deployments(
{"deployer": record.attributes.deployer, "payment": tx.hash}, all=True
)
if len(used):
# Fetch the app name from request record
used_request = laconic.get_record(used[0].attributes.request, require=True)
# Check that payment was used for deployment of same application
if record.attributes.application != used_request.attributes.application:
logger.log(f"{record.id}: payment {tx.hash} already used on a different application deployment {used}")
return False
used = laconic.app_deployment_removals(
{"deployer": record.attributes.deployer, "payment": tx.hash}, all=True
)
if len(used):
logger.log(
f"{record.id}: payment {tx.hash} already used on deployment removal {used}"
)
return False
return True
# If we get here, the transaction hash wasn't found in the laconic testnet
# Let's check if it's a valid Cosmos ATOM payment if configuration is available
if atom_payment_address:
logger.log(f"{record.id}: checking if payment is a valid Cosmos ATOM transaction")
try:
import requests
# Use the webapp-deployment-status-api to verify the ATOM payment
deployer_record = laconic.get_record(record.attributes.deployer)
if not deployer_record or not deployer_record.attributes.apiUrl:
logger.log(f"{record.id}: cannot find deployer API URL to verify ATOM payment")
return False
api_url = deployer_record.attributes.apiUrl
verify_url = f"{api_url}/verify/atom-payment"
# Make a request to the API to verify the ATOM payment
# Pass markAsUsed=true to prevent this transaction from being used again
response = requests.post(
verify_url,
json={
"txHash": record.attributes.payment,
"minAmount": atom_min_amount,
"markAsUsed": True
},
timeout=10
)
if response.status_code != 200:
logger.log(f"{record.id}: ATOM payment verification API request failed with status {response.status_code}")
return False
result = response.json()
if not result.get("valid", False):
logger.log(f"{record.id}: ATOM payment verification failed: {result.get('reason', 'unknown reason')}")
return False
# Payment is valid
logger.log(f"{record.id}: ATOM payment verified successfully, amount: {result.get('amount')} ATOM")
return True
except Exception as e:
logger.log(f"{record.id}: error verifying ATOM payment: {str(e)}")
return False
logger.log(f"{record.id}: payment tx {record.attributes.payment} not found in laconic testnet and ATOM payment verification not configured")
return False
def confirm_auction(laconic: LaconicRegistryClient, record, deployer_lrn, payment_address, logger): def confirm_auction(laconic: LaconicRegistryClient, record, deployer_lrn, payment_address, logger):