From fea6c5578be2f756e0fd99d603bee7bbe4947ef3 Mon Sep 17 00:00:00 2001 From: prathamesh0 Date: Mon, 3 Apr 2023 14:22:59 +0530 Subject: [PATCH] Remove unnecessary todos --- .../config/fixturenet-optimism/optimism-contracts/run.sh | 7 +++---- .../container-build/cerc-optimism-contracts/Dockerfile | 1 - 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/app/data/config/fixturenet-optimism/optimism-contracts/run.sh b/app/data/config/fixturenet-optimism/optimism-contracts/run.sh index 473b8743..f4aa1abf 100755 --- a/app/data/config/fixturenet-optimism/optimism-contracts/run.sh +++ b/app/data/config/fixturenet-optimism/optimism-contracts/run.sh @@ -43,14 +43,13 @@ yarn hardhat send-balance --to "${BATCHER_ADDRESS}" --amount 1000 --private-key echo "Balances sent to L2 accounts" # Select a finalized L1 block as the starting point for roll ups -# TODO Use web3.js to get the latest finalized block -until CAST_OUTPUT=$(cast block finalized --rpc-url "$L1_RPC"); do +until FINALIZED_BLOCK=$(cast block finalized --rpc-url "$L1_RPC"); do echo "Waiting for a finalized L1 block to exist, retrying after 10s" sleep 10 done -L1_BLOCKHASH=$(echo "$CAST_OUTPUT" | awk '/hash/{print $2}') -L1_BLOCKTIMESTAMP=$(echo "$CAST_OUTPUT" | awk '/timestamp/{print $2}') +L1_BLOCKHASH=$(echo "$FINALIZED_BLOCK" | awk '/hash/{print $2}') +L1_BLOCKTIMESTAMP=$(echo "$FINALIZED_BLOCK" | awk '/timestamp/{print $2}') # Update the deployment config sed -i 's/"l2OutputOracleStartingTimestamp": TIMESTAMP/"l2OutputOracleStartingTimestamp": '"$L1_BLOCKTIMESTAMP"'/g' deploy-config/getting-started.json diff --git a/app/data/container-build/cerc-optimism-contracts/Dockerfile b/app/data/container-build/cerc-optimism-contracts/Dockerfile index 4f244bab..cdc98b08 100644 --- a/app/data/container-build/cerc-optimism-contracts/Dockerfile +++ b/app/data/container-build/cerc-optimism-contracts/Dockerfile @@ -1,4 +1,3 @@ -# TODO: Use a node alpine image FROM cerc/foundry:local # Install node (local foundry is a debian based image)