From fdd3bbde0c764625572b48d15ca86f308ee23d8f Mon Sep 17 00:00:00 2001
From: Prathamesh Musale <prathamesh.musale0@gmail.com>
Date: Thu, 16 May 2024 18:47:54 +0530
Subject: [PATCH] Use time series for RPC errors panel on watcher dashboard

---
 .../grafana/dashboards/watcher-dashboard.json | 63 +++++++++----------
 1 file changed, 30 insertions(+), 33 deletions(-)

diff --git a/stack_orchestrator/data/config/monitoring/grafana/dashboards/watcher-dashboard.json b/stack_orchestrator/data/config/monitoring/grafana/dashboards/watcher-dashboard.json
index 0b62be5e..d558c839 100644
--- a/stack_orchestrator/data/config/monitoring/grafana/dashboards/watcher-dashboard.json
+++ b/stack_orchestrator/data/config/monitoring/grafana/dashboards/watcher-dashboard.json
@@ -1367,17 +1367,24 @@
                 "axisColorMode": "text",
                 "axisLabel": "",
                 "axisPlacement": "auto",
-                "fillOpacity": 90,
+                "barAlignment": 0,
+                "drawStyle": "line",
+                "fillOpacity": 0,
                 "gradientMode": "none",
                 "hideFrom": {
                   "legend": false,
                   "tooltip": false,
                   "viz": false
                 },
+                "insertNulls": false,
+                "lineInterpolation": "linear",
                 "lineWidth": 1,
+                "pointSize": 5,
                 "scaleDistribution": {
                   "type": "linear"
                 },
+                "showPoints": "auto",
+                "spanNulls": false,
                 "thresholdsStyle": {
                   "mode": "off"
                 }
@@ -1403,26 +1410,16 @@
           },
           "id": 28,
           "options": {
-            "barRadius": 0,
-            "barWidth": 0.97,
-            "fullHighlight": false,
-            "groupWidth": 1,
             "legend": {
               "calcs": [],
               "displayMode": "list",
               "placement": "bottom",
               "showLegend": true
             },
-            "orientation": "auto",
-            "showValue": "auto",
-            "stacking": "none",
             "tooltip": {
               "mode": "single",
               "sort": "none"
-            },
-            "xField": "Time",
-            "xTickLabelRotation": 0,
-            "xTickLabelSpacing": 0
+            }
           },
           "pluginVersion": "10.2.3",
           "targets": [
@@ -1438,15 +1435,15 @@
               "format": "time_series",
               "fullMetaSearch": false,
               "includeNullMetadata": true,
-              "instant": true,
+              "instant": false,
               "legendFormat": "{{method}}, {{provider}}",
-              "range": false,
+              "range": true,
               "refId": "A",
               "useBackend": false
             }
           ],
           "title": "ETH RPC request failures",
-          "type": "barchart"
+          "type": "timeseries"
         },
         {
           "datasource": {
@@ -1561,17 +1558,24 @@
                 "axisColorMode": "text",
                 "axisLabel": "",
                 "axisPlacement": "auto",
-                "fillOpacity": 90,
+                "barAlignment": 0,
+                "drawStyle": "line",
+                "fillOpacity": 0,
                 "gradientMode": "none",
                 "hideFrom": {
                   "legend": false,
                   "tooltip": false,
                   "viz": false
                 },
+                "insertNulls": false,
+                "lineInterpolation": "linear",
                 "lineWidth": 1,
+                "pointSize": 5,
                 "scaleDistribution": {
                   "type": "linear"
                 },
+                "showPoints": "auto",
+                "spanNulls": false,
                 "thresholdsStyle": {
                   "mode": "off"
                 }
@@ -1597,26 +1601,16 @@
           },
           "id": 30,
           "options": {
-            "barRadius": 0,
-            "barWidth": 0.97,
-            "fullHighlight": false,
-            "groupWidth": 1,
             "legend": {
               "calcs": [],
               "displayMode": "list",
               "placement": "bottom",
               "showLegend": true
             },
-            "orientation": "auto",
-            "showValue": "auto",
-            "stacking": "none",
             "tooltip": {
               "mode": "single",
               "sort": "none"
-            },
-            "xField": "Time",
-            "xTickLabelRotation": 0,
-            "xTickLabelSpacing": 0
+            }
           },
           "pluginVersion": "10.2.3",
           "targets": [
@@ -1632,15 +1626,15 @@
               "format": "time_series",
               "fullMetaSearch": false,
               "includeNullMetadata": true,
-              "instant": true,
+              "instant": false,
               "legendFormat": "{{method}}, {{provider}}",
-              "range": false,
+              "range": true,
               "refId": "A",
               "useBackend": false
             }
           ],
           "title": "Total ETH RPC request failures (across all watchers)",
-          "type": "barchart"
+          "type": "timeseries"
         },
         {
           "datasource": {
@@ -1805,7 +1799,8 @@
                 "mode": "absolute",
                 "steps": [
                   {
-                    "color": "green"
+                    "color": "green",
+                    "value": null
                   }
                 ]
               }
@@ -1950,7 +1945,8 @@
                 "mode": "absolute",
                 "steps": [
                   {
-                    "color": "green"
+                    "color": "green",
+                    "value": null
                   }
                 ]
               }
@@ -2097,7 +2093,8 @@
                 "mode": "absolute",
                 "steps": [
                   {
-                    "color": "green"
+                    "color": "green",
+                    "value": null
                   }
                 ]
               }