From 7d00228ca2e0043c82b008564bbae092b3d3b752 Mon Sep 17 00:00:00 2001
From: David Boreham <david@bozemanpass.com>
Date: Thu, 19 Jan 2023 13:30:01 -0700
Subject: [PATCH] Remove result code check

Former-commit-id: 6faa933d42a6f80abecee635c8497d9d3502010d
---
 app/build_npms.py | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/app/build_npms.py b/app/build_npms.py
index 6801dd7d..526f78f1 100644
--- a/app/build_npms.py
+++ b/app/build_npms.py
@@ -85,18 +85,19 @@ def command(ctx, include, exclude):
                 print(f"Executing: {build_command}")
             envs = {"CERC_NPM_AUTH_TOKEN": os.environ["CERC_NPM_AUTH_TOKEN"]} | ({"CERC_SCRIPT_DEBUG": "true"} if debug else {})
             try:
-                build_result = docker.run("cerc/builder-js",
-                                          remove=True,
-                                          interactive=True,
-                                          tty=True,
-                                          user=f"{os.getuid()}:{os.getgid()}",
-                                          envs=envs,
-                                          add_hosts=[("gitea.local", "host-gateway")],
-                                          volumes=[(repo_full_path, "/workspace")],
-                                          command=build_command
-                                          )
-                # TODO: check result in build_result.returncode
-                print(f"Result is: {build_result}")
+                docker.run("cerc/builder-js",
+                           remove=True,
+                           interactive=True,
+                           tty=True,
+                           user=f"{os.getuid()}:{os.getgid()}",
+                           envs=envs,
+                           add_hosts=[("gitea.local", "host-gateway")],
+                           volumes=[(repo_full_path, "/workspace")],
+                           command=build_command
+                           )
+                # Note that although the docs say that build_result should contain
+                # the command output as a string, in reality it is always the empty string.
+                # Since we detect errors via catching exceptions below, we can safely ignore it here.
             except DockerException as e:
                 print(f"FATAL error executing build in container:\n {e}")
         else: