cerc-io/stack-orchestrator
13
1
Fork 3
Code Issues 115 Pull Requests 23 Actions Packages Projects Releases 486 Wiki Activity

fix(deploy): merge volumes from stack init() instead of overwriting
Some checks failed
Lint Checks / Run linter (push) Has been cancelled
Details
Lint Checks / Run linter (pull_request) Successful in 24m14s
Details
Deploy Test / Run deploy test suite (pull_request) Successful in 29m14s
Details
K8s Deploy Test / Run deploy test suite on kind/k8s (pull_request) Failing after 33m1s
Details
K8s Deployment Control Test / Run deployment control suite on kind/k8s (pull_request) Failing after 34m3s
Details
Webapp Test / Run webapp test suite (pull_request) Successful in 33m23s
Details
Smoke Test / Run basic test suite (pull_request) Successful in 33m49s
Details

Browse Source 
Previously, volumes defined in a stack's commands.py init() function
were being overwritten by volumes discovered from compose files.
This prevented stacks from adding infrastructure volumes like caddy-data
that aren't defined in the compose files.

Now volumes are merged, with init() volumes taking precedence over
compose-discovered defaults.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
A. F. Dudley 2026-01-25 17:27:51 -05:00
parent 79b7870a6a
commit 6ff3da76ee
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
stack_orchestrator/deploy/deployment_create.py
View File

@ -469,7 +469,10 @@ def init_operation(
# Docker Compose and kind: use relative paths
volume_descriptors[named_volume] = f"./data/{named_volume}"
if volume_descriptors:
spec_file_content["volumes"] = volume_descriptors
# Merge with existing volumes from stack init()
# init() volumes take precedence over compose defaults
orig_volumes = spec_file_content.get("volumes", {})
spec_file_content["volumes"] = {**volume_descriptors, **orig_volumes}
if configmap_descriptors:
spec_file_content["configmaps"] = configmap_descriptors