Path is not a context manager in python 3.13 (#971)
Some checks failed
Lint Checks / Run linter (push) Successful in 13m45s
Publish / Build and publish (push) Successful in 15m24s
Deploy Test / Run deploy test suite (push) Successful in 17m26s
Webapp Test / Run webapp test suite (push) Successful in 19m19s
Smoke Test / Run basic test suite (push) Successful in 21m22s
Database Test / Run database hosting test on kind/k8s (push) Successful in 25m36s
Container Registry Test / Run contaier registry hosting test on kind/k8s (push) Failing after 4m54s
External Stack Test / Run external stack test suite (push) Successful in 5m55s
Fixturenet-Laconicd-Test / Run Laconicd fixturenet and Laconic CLI tests (push) Successful in 16m16s
K8s Deploy Test / Run deploy test suite on kind/k8s (push) Has started running
Some checks failed
Lint Checks / Run linter (push) Successful in 13m45s
Publish / Build and publish (push) Successful in 15m24s
Deploy Test / Run deploy test suite (push) Successful in 17m26s
Webapp Test / Run webapp test suite (push) Successful in 19m19s
Smoke Test / Run basic test suite (push) Successful in 21m22s
Database Test / Run database hosting test on kind/k8s (push) Successful in 25m36s
Container Registry Test / Run contaier registry hosting test on kind/k8s (push) Failing after 4m54s
External Stack Test / Run external stack test suite (push) Successful in 5m55s
Fixturenet-Laconicd-Test / Run Laconicd fixturenet and Laconic CLI tests (push) Successful in 16m16s
K8s Deploy Test / Run deploy test suite on kind/k8s (push) Has started running
Reviewed-on: #971 Reviewed-by: rachmaninovquar <rachmaninovquar@noreply.git.vdb.to>
This commit is contained in:
parent
0e814bd4da
commit
34f3b719e4
@ -56,9 +56,8 @@ class DeploymentContext:
|
||||
self.stack.init_from_file(self.get_stack_file())
|
||||
deployment_file_path = self.get_deployment_file()
|
||||
if deployment_file_path.exists():
|
||||
with deployment_file_path:
|
||||
obj = get_yaml().load(open(deployment_file_path, "r"))
|
||||
self.id = obj[constants.cluster_id_key]
|
||||
obj = get_yaml().load(open(deployment_file_path, "r"))
|
||||
self.id = obj[constants.cluster_id_key]
|
||||
# Handle the case of a legacy deployment with no file
|
||||
# Code below is intended to match the output from _make_default_cluster_name()
|
||||
# TODO: remove when we no longer need to support legacy deployments
|
||||
|
@ -92,9 +92,8 @@ class Spec:
|
||||
return self.obj.get(item, default)
|
||||
|
||||
def init_from_file(self, file_path: Path):
|
||||
with file_path:
|
||||
self.obj = get_yaml().load(open(file_path, "r"))
|
||||
self.file_path = file_path
|
||||
self.obj = get_yaml().load(open(file_path, "r"))
|
||||
self.file_path = file_path
|
||||
|
||||
def get_image_registry(self):
|
||||
return self.obj.get(constants.image_registry_key)
|
||||
|
@ -27,5 +27,4 @@ class Stack:
|
||||
self.name = name
|
||||
|
||||
def init_from_file(self, file_path: Path):
|
||||
with file_path:
|
||||
self.obj = get_yaml().load(open(file_path, "r"))
|
||||
self.obj = get_yaml().load(open(file_path, "r"))
|
||||
|
@ -180,9 +180,7 @@ def get_k8s_dir():
|
||||
def get_parsed_deployment_spec(spec_file):
|
||||
spec_file_path = Path(spec_file)
|
||||
try:
|
||||
with spec_file_path:
|
||||
deploy_spec = get_yaml().load(open(spec_file_path, "r"))
|
||||
return deploy_spec
|
||||
return get_yaml().load(open(spec_file_path, "r"))
|
||||
except FileNotFoundError as error:
|
||||
# We try here to generate a useful diagnostic error
|
||||
print(f"Error: spec file: {spec_file_path} does not exist")
|
||||
|
Loading…
Reference in New Issue
Block a user