mirror of
https://github.com/ethereum/solidity
synced 2023-10-03 13:03:40 +00:00
12bca24774
Without path condition, verification targets created inside ternary operator ignore the condition of the operator inside the branches. This led to false positives. Further updates: - Function calls should consider the conditions under which they are called, otherwise the analysis may report false positives. The fix proposed here is to add the current path condition to the edge that propagates error from a function call. - Increment error index after function call This is necessary for the analysis of the ternary operator to work correctly. No information should leak from a function call inside a ternary operator in the first branch to the second branch, including whether or not an error would have occured in the first branch. However, for the execution that continues after the function call, we still need to ensure that under the current path condition the error has not occurred in that function call. It would be better to isolate the analysis of the branches to separate clauses, but I do not see an easy way for that now. In this way, even though the function call in first branch is included in the clause of the second branch, no information leaks. - Additonal test for ternary operator This tests the behaviour of SMTChecker on ternary operator with function calls inside both branches. Specifically, it tests that SMTChecker successfully detects a violation of a verification target in the second branch when the same target is present also in the first branch, but there it cannot be triggered because of the operator's condition. |
||
|---|---|---|
| .. | ||
| ABIJson | ||
| analysis | ||
| ASTJSON | ||
| errorRecoveryTests | ||
| gasTests | ||
| interface | ||
| lsp | ||
| memoryGuardTests | ||
| semanticTests | ||
| smtCheckerTests | ||
| syntaxTests | ||
| util | ||
| ABIDecoderTests.cpp | ||
| ABIEncoderTests.cpp | ||
| ABIJsonTest.cpp | ||
| ABIJsonTest.h | ||
| ABITestsCommon.h | ||
| AnalysisFramework.cpp | ||
| AnalysisFramework.h | ||
| Assembly.cpp | ||
| ASTJSONTest.cpp | ||
| ASTJSONTest.h | ||
| ErrorCheck.cpp | ||
| ErrorCheck.h | ||
| GasCosts.cpp | ||
| GasMeter.cpp | ||
| GasTest.cpp | ||
| GasTest.h | ||
| Imports.cpp | ||
| InlineAssembly.cpp | ||
| LibSolc.cpp | ||
| MemoryGuardTest.cpp | ||
| MemoryGuardTest.h | ||
| Metadata.cpp | ||
| SemanticTest.cpp | ||
| SemanticTest.h | ||
| SemVerMatcher.cpp | ||
| SMTCheckerTest.cpp | ||
| SMTCheckerTest.h | ||
| SolidityCompiler.cpp | ||
| SolidityEndToEndTest.cpp | ||
| SolidityExecutionFramework.cpp | ||
| SolidityExecutionFramework.h | ||
| SolidityExpressionCompiler.cpp | ||
| SolidityNameAndTypeResolution.cpp | ||
| SolidityNatspecJSON.cpp | ||
| SolidityOptimizer.cpp | ||
| SolidityParser.cpp | ||
| SolidityTypes.cpp | ||
| StandardCompiler.cpp | ||
| SyntaxTest.cpp | ||
| SyntaxTest.h | ||
| ViewPureChecker.cpp | ||