Commit Graph

3027 Commits

Author SHA1 Message Date
Harikrishnan Mulackal
eee30b6ead
Merge pull request #12504 from brien-tech/patch-1
Fixing typo in "smart contracts"
2022-01-10 13:43:23 +05:30
Brien
790e7f42a1
Fixing typo in "smart contracts" 2022-01-10 02:29:51 -05:00
Mohamed Safouen Bouabid
4c20821e6d Explaining payable(msg.sender)
At this point of the documentation a new Solidity learner will not understand this line without further explanation:
if (!payable(msg.sender).send(amount)) {
It should explain how msg.sender is of type "address" and not "address payable" so it cannot send or receive Ether. Therefore it must be explicitly converted to payable.
2022-01-10 12:49:30 +05:30
Esquith Allen
b1ef5de496 fix typo 2022-01-05 21:58:41 -05:00
chriseth
c16867cb83
Merge pull request #12272 from ethereum/equalStoreEliminator
Equal store eliminator.
2022-01-05 11:24:59 +01:00
William Entriken
c798ac472e Typo: SemVer 2022-01-04 18:59:40 -05:00
Daniel Kirchner
cac0f203a2
Merge pull request #12467 from ethereum/fixMappingExample
Fix mapping example.
2022-01-04 18:23:57 +01:00
Braden Watling
bb16c1943c Fix gas retaining statement.
According to https://docs.soliditylang.org/en/v0.8.11/introduction-to-smart-contracts.html?highlight=63%2F64#message-calls, the caller forwards 63/64th of its gas, but here we seem to contradict that by saying the caller retains 63/64th of its gas.
2022-01-04 11:10:31 +01:00
Braden Watling
6fe1ee6a8a
Fix typo in control-structures.rst
I'm learning Solidity by reading these docs and found this statement confusing. I'm fairly certain that the correct description here is that the *callee* changes get reverted, but the caller is able to react to the failures.

I tested this with the following snippet in Remix, which resulted in a successful transaction when deployed:

```
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.7;

contract A {
    uint public value;

    function a(uint newValue, bool shouldRevert) external {
        value = newValue;
        if (shouldRevert) {
            revert();
        }
    }
}

contract B {
    function b() external {
        A a = new A();
        try a.a(50, false) {
            assert(a.value() == 50);
        } catch {
            assert(false);
        }
        a = new A();
        try a.a(50, true) {
            assert(false);
        } catch {
            assert(a.value() == 0);
        }
    }
}
```
2022-01-03 17:22:23 -05:00
chriseth
b354c81a63 Documentation 2022-01-03 15:52:05 +01:00
chriseth
57474917a0 Clarify which functions are added. 2022-01-03 15:38:39 +01:00
Pranay Reddy
f30130888e Added specificity to data location.
Added the specificity that bytes1[] and bytes differ because of padding only in memory data location. Added extra sentence that they are similar when used in storage data location.
2022-01-03 12:47:51 +05:30
chriseth
0010027e17 Fix mapping example. 2021-12-30 15:28:09 +01:00
Franziska Heintel
4456eeb6bb
[DOCS] update contributing section meeting link 2021-12-29 16:06:05 +01:00
Semar Augusto
6fbfa33486
Update docs/examples/voting.rst
Co-authored-by: Bhargava Shastry <bshastry@ethereum.org>
2021-12-29 07:04:13 -03:00
semaraugusto
942a3301dc fix issue with delegating votes to people who cannot vote. That made it so that if wallet A delegated to wallet B and B had no rights to vote, than B would lose out on its own vote 2021-12-29 00:17:15 -03:00
Kamil Śliwak
dece5f4de2 pylint: Enable and fix redefined-builtin warnings 2021-12-21 15:30:11 +01:00
Kamil Śliwak
5b10ff1216 pylint: Enable and fix singleton-comparison warnings 2021-12-21 15:30:11 +01:00
chriseth
25a3bf2df0 Set release date. 2021-12-20 13:15:58 +01:00
GitHubPang
1b0cef4624
Fix a few typos 2021-12-20 10:56:39 +08:00
Marenz
7a96953e78 Implement typechecked abi.encodeCall() 2021-12-16 17:35:58 +01:00
chriseth
c15ef45d29 Explanation about operators. 2021-12-15 18:37:18 +01:00
Alessandro Coglio
d17f7206ad Improve description of break/continue restrictions.
This is as discussed on Element, with enhancements discussed with @cameel.
2021-12-13 21:59:25 -08:00
dinah
f0aadcf577 Remove stale link. 2021-12-13 12:04:23 +01:00
Omkar Nikhal
01d45a1952 Remove redundant typo 2021-12-13 11:36:07 +01:00
chriseth
d414153258 Some clarifications on literals. 2021-12-06 17:36:34 +01:00
minami
6bafeca8a2 Fix yul 2021-12-05 16:58:03 +09:00
minami
907405e2e0 Fix units-and-global-variables 2021-12-05 16:57:59 +09:00
minami
25a26d2f8b Fix cheatsheet 2021-12-05 16:57:48 +09:00
Saska Karsi
105de2561a
rm trailing comma in style-guide.rst example 2021-12-03 01:11:04 +02:00
chriseth
829fe6615b Fix Yul example. 2021-12-01 16:23:26 +01:00
chriseth
d2585fd91d
Merge pull request #12322 from tzann/patch-1
Fix ExpressionSplitter example
2021-12-01 15:44:57 +01:00
Tynan Richards
d56fb3afff Fix ExpressionSplitter example
Fix error (0x123 and 0x456 were swapped) and split constants into expressions
2021-12-01 15:43:50 +01:00
Dallon Asnes
310f74302d Add fixed size type details to encodePacked doc 2021-11-29 15:31:52 -06:00
nishant-sachdeva
bd399e37e3 restoring the RTD section. Downloads section to still be above versions section 2021-11-30 00:20:27 +05:30
nishant-sachdeva
ecf6c8e122 trailing whitespace removed in index.rst as per the requirements of a syntax test 2021-11-26 09:29:27 +05:30
nishant-sachdeva
5e59325d06 relocated downloads section in versions flyout menu and added downloads Hint in index.html 2021-11-26 09:29:27 +05:30
Kamil Śliwak
9b6a687a24
Merge pull request #12308 from dallonasnes/docs-typo-fix
Fix typo in intro to smart contracts
2021-11-22 23:56:46 +01:00
Dallon Asnes
ef3c562160
Fix typo 2021-11-22 15:18:43 -06:00
Alex Beregszaszi
b36a3c6bf5
Fix documentation for valid ASCII string literals 2021-11-20 22:41:19 +00:00
Alessandro Coglio
d3b2463166 Improve description of literal evaluation. 2021-11-10 23:17:47 -08:00
Daniel Kirchner
f2d9a806e0 Document change to BlockFlattener. 2021-11-09 13:29:10 +01:00
chriseth
45c9dbe174 Sort changelog and set release date. 2021-11-08 17:28:53 +01:00
chriseth
df85d26406 Update ir-breaking-changes and make it visible. 2021-11-08 17:23:17 +01:00
chriseth
4f8719326c
Merge pull request #12205 from ethereum/optimizeextocedsizecheck
Skip extcodesize check if return data is expected.
2021-11-08 16:05:03 +01:00
chriseth
f320a95dd9 Update documentation. 2021-11-08 14:58:09 +01:00
chriseth
aa4d3cabf1 Clarify `pure`. 2021-11-08 13:22:35 +01:00
chriseth
ea3c34a082
Merge pull request #12254 from ethereum/optimizerDocsForLoopInitRewriter
Remove incorrect outer block from for loop init rewriter documentation.
2021-11-08 11:55:05 +01:00
Daniel Kirchner
be552683c9 Remove incorrect outer block from for loop init rewriter documentation. 2021-11-08 10:58:28 +01:00
Shivam Rajput
063d00adc8
0.y.z makes more sense than 0.x for the current version. 2021-11-07 10:41:48 +05:30
Daniel Kirchner
a0dee79ad2 Remove install_deps script. 2021-11-04 12:07:27 +01:00
José López
b4a527039f fixed example address payable 2021-11-03 20:21:31 -03:00
Marenz
61519da4f0 Fix wrong path to isoltest in docs 2021-10-27 14:16:50 +02:00
Leo Alt
d04ad57ee7 Docs 2021-10-26 11:30:30 +02:00
chriseth
719b70893f
Merge pull request #12144 from ethereum/clarify-linkersymbol-docs-regarding-fqln
Clarify that `linkersymbol()` accepts but does not require a fully qualified library name
2021-10-26 11:10:34 +02:00
Adam Bliss
3387e134d7
Fix typo compiler->constructor. 2021-10-24 08:22:34 -04:00
Gyeonghun Park
921d04451b
Fix typo in ir-breaking-changes.rst 2021-10-22 10:00:26 +09:00
William Entriken
2278673936 Fix formatting 2021-10-20 18:12:34 +02:00
William Entriken
121f9c3b74 More strongly recommend to use the latest version 2021-10-19 13:44:58 +02:00
chriseth
7fba9ab245
Merge pull request #11923 from miohtama/patch-4
Clarify `block.*` and `tx.*` values in off-chain calls
2021-10-19 13:36:22 +02:00
Marenz
8dfb390c7e Enhance documentation in regards to modifiers and return 2021-10-18 14:22:09 +02:00
Mikko Ohtamaa
025bbbad82 Clarify block.* and tx.* values in off-chain calls
Looks like this may vary between different EVM implementations and confuses users.
2021-10-15 19:15:12 +02:00
Mariela Mantle
d684494389 feat(docs): get mismatched Yul optimizer step lists back in sync 2021-10-15 18:47:25 +02:00
Kamil Śliwak
d846410172 yul.rst: Clarify that linkersymbol() accepts but does not require a fully qualified library name 2021-10-14 20:57:15 +02:00
chriseth
d443fe415d
Merge pull request #12126 from MrBrain295/patch-1
Minor rewording of ` docs/examples/micropayment.rst `
2021-10-14 15:15:16 +02:00
MrBrain295
ac64ae56a1 Minor rewording. 2021-10-14 15:09:18 +02:00
Kamil Śliwak
6aa9633a02 docs: Add more bottom padding to the menu to prevent the index link from being obscured by the toggle 2021-10-14 14:15:29 +02:00
Kamil Śliwak
ed722700cd docs: Put the index menu item into a list prevent it from being styled as unfolded 2021-10-14 14:05:14 +02:00
Kamil Śliwak
ac8020d4a7 contributing.rst: Tweak details about the location of evmone and hera 2021-10-13 17:31:52 +02:00
Christian Parpart
5b926bee3f [docs] contributing.rst: Documents evmone.so loading search paths.
Co-authored-by: Kamil Śliwak <kamil.sliwak@codepoets.it>
2021-10-13 12:05:16 +02:00
Christian Parpart
b1dd0d0d02 Properly compute source mappings for immutables. 2021-10-12 17:56:17 +02:00
Kamil Śliwak
a9e794c872 Expose --debug-info/settings.debug.debugInfo option 2021-10-11 20:34:48 +02:00
chriseth
b986c2151a Add inline assembly section to cleanup. 2021-10-11 14:25:03 +02:00
Kamil Śliwak
d22cd235cf Rename share-solid.svg to avoid it being blocked by adblockers 2021-10-08 13:57:49 +02:00
Kamil Śliwak
f245f8b473 footer.html: Put credits link in a paragraph to add more spacing 2021-10-07 21:22:12 +02:00
Kamil Śliwak
6adfe88211 custom.css: Restore braces that disappeared in a rebase 2021-10-07 21:20:51 +02:00
Kamil Śliwak
b7942219df Include language and compiler version in Remix code links 2021-10-07 18:25:01 +02:00
Kamil Śliwak
416b13850f Sphinx extension for adding Remix links to code snippets 2021-10-07 18:25:00 +02:00
Kamil Śliwak
cd7db7faeb Add an arrow icon for Remix link, with proper attribution 2021-10-07 18:23:56 +02:00
4molybdenum2
551c3ae17a Adjust Colors for the Solidity Docs 2021-10-07 16:23:30 +02:00
Kamil Śliwak
0043eca672 Consistent indentation in doc config, templates and static files 2021-10-07 16:23:27 +02:00
Marenz
98dd78362e Add `.address and .selector` in inside assembly for external function pointers 2021-10-04 18:05:57 +02:00
sgmoore
ca232142be
Update value-types.rst - fix typo
Fix typo at line 69.
2021-10-02 20:32:25 -07:00
Leonardo
6d806359be
Merge pull request #11873 from soroosh-sdi/cmake-check-z3-latest
Require latest Z3 by default and allow relaxing the requirement with `STRICT_Z3_VERSION=OFF`
2021-10-01 12:58:03 +02:00
chriseth
1a7faef0db Set release date. 2021-09-29 14:00:57 +02:00
hrkrshnn
9d8a0a6f82 Buglist entry for UserDefinedValueTypesBug 2021-09-29 11:54:00 +02:00
chriseth
ffe6e7dcf4 Bug list entry about the signed immutables bug. 2021-09-29 10:12:05 +02:00
chriseth
4e28020ff5 Set release date. 2021-09-27 15:43:59 +02:00
chriseth
321e362789
Merge pull request #12024 from ethereum/require-boost-1.77-on-windows
Require Boost 1.77 on Windows
2021-09-27 15:41:21 +02:00
Kamil Śliwak
e3a3829f97 Increase minimum Boost version to 1.77 on Windows 2021-09-27 13:15:57 +02:00
Kamil Śliwak
f909555022 Treat ambiguous imports as errors 2021-09-27 13:14:23 +02:00
Kamil Śliwak
9975b5e26b Detect source unit name collisions between paths specified on the command line 2021-09-27 13:14:23 +02:00
Kamil Śliwak
c8a7a1da7c Add --include-path option 2021-09-27 13:14:23 +02:00
Kamil Śliwak
60b2f2b913 Documentation for --allow-paths and changelog entry for fixes 2021-09-27 13:14:10 +02:00
chriseth
d5c869f5d6
Merge pull request #12026 from CrimsonGlory/CrimsonGlory-patch-3
[docs] Add bitwise assignment operators
2021-09-27 12:26:00 +02:00
CrimsonGlory
e2bb3a3347
[docs] Add bitwise assignment operators
Add bitwise assignment operators to the list of operators involving LValues [skip ci]
2021-09-25 21:48:20 -03:00
soroosh-sdi
8b04ac38ab Require latest Z3 by default and allow relaxing the requirement with STRICT_Z3_VERSION=OFF
Signed-off-by: soroosh-sdi <soroosh.sardari@gmail.com>
2021-09-24 22:09:56 +03:30
Kamil Śliwak
caccd0a3e0 Always refer to the latest version of Boost in URLs 2021-09-24 15:35:33 +02:00
Alessandro Coglio
0ac441ac73 Clarify interpretation of literals.
This is based on discussions on Gitter.
2021-09-20 11:59:59 +02:00
chriseth
ccfc306942
Merge pull request #11937 from istareatscreens/patch-1
Reword External Function Calls paragraph in docs to improve clarity
2021-09-15 12:44:37 +02:00